Re: [edk2] [PATCH] MdePkg/SecPeiDxeTimerLibCpu: Consume UefiCpuPkg LAPIC code.

2017-07-27 Thread Marvin Häuser
; > -----Original Message- > > > > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On > > > > Behalf Of Marvin H?user > > > > Sent: Wednesday, July 26, 2017 4:34 PM > > > > To: edk2-devel@lists.01.org > > > > Cc: Kinney, Micha

Re: [edk2] [PATCH] MdePkg/SecPeiDxeTimerLibCpu: Consume UefiCpuPkg LAPIC code.

2017-07-27 Thread Gao, Liming
@lists.01.org] On Behalf Of Marvin > H?user > Sent: Thursday, July 27, 2017 9:49 PM > To: edk2-devel@lists.01.org > Cc: Kinney, Michael D ; Fan, Jeff > ; Gao, Liming > Subject: Re: [edk2] [PATCH] MdePkg/SecPeiDxeTimerLibCpu: Consume UefiCpuPkg > LAPIC code. > > Hey

Re: [edk2] [PATCH] MdePkg/SecPeiDxeTimerLibCpu: Consume UefiCpuPkg LAPIC code.

2017-07-27 Thread Marvin Häuser
[mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > > Marvin H?user > > Sent: Wednesday, July 26, 2017 4:34 PM > > To: edk2-devel@lists.01.org > > Cc: Kinney, Michael D ; Fan, Jeff > > > > Subject: Re: [edk2] [PATCH] MdePkg/SecPeiDxeTimerLibCpu: Consume > Uef

Re: [edk2] [PATCH] MdePkg/SecPeiDxeTimerLibCpu: Consume UefiCpuPkg LAPIC code.

2017-07-27 Thread Gao, Liming
c: Kinney, Michael D ; Fan, Jeff > > Subject: Re: [edk2] [PATCH] MdePkg/SecPeiDxeTimerLibCpu: Consume UefiCpuPkg > LAPIC code. > > Hey Jeff, > > That would definitely fix the compilation issue. > Do I see it right that for 32-bit platforms, it's just ApicBase

Re: [edk2] [PATCH] MdePkg/SecPeiDxeTimerLibCpu: Consume UefiCpuPkg LAPIC code.

2017-07-26 Thread Marvin Häuser
t; To: edk2-devel@lists.01.org > Cc: Kinney, Michael D > Subject: Re: [edk2] [PATCH] MdePkg/SecPeiDxeTimerLibCpu: Consume > UefiCpuPkg LAPIC code. > > Hi Michael, > > Sorry, I did not notice that UefiCpuPkg already has a similiar library. > Could you please answer my question

Re: [edk2] [PATCH] MdePkg/SecPeiDxeTimerLibCpu: Consume UefiCpuPkg LAPIC code.

2017-07-25 Thread Fan, Jeff
hael D Subject: Re: [edk2] [PATCH] MdePkg/SecPeiDxeTimerLibCpu: Consume UefiCpuPkg LAPIC code. Hi Michael, Sorry, I did not notice that UefiCpuPkg already has a similiar library. Could you please answer my question regarding the mask value which I considered incorrect nevertheless? I am get

Re: [edk2] [PATCH] MdePkg/SecPeiDxeTimerLibCpu: Consume UefiCpuPkg LAPIC code.

2017-07-24 Thread Marvin Häuser
; Marvin. > > > > > -Original Message- > > > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On > > Behalf Of > > > Marvin Häuser > > > Sent: Sunday, July 23, 2017 12:12 PM > > > To: edk2-devel@lists.01.org > >

Re: [edk2] [PATCH] MdePkg/SecPeiDxeTimerLibCpu: Consume UefiCpuPkg LAPIC code.

2017-07-24 Thread Kinney, Michael D
al Message- > > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On > Behalf Of > > Marvin Häuser > > Sent: Sunday, July 23, 2017 12:12 PM > > To: edk2-devel@lists.01.org > > Cc: michael.d.kin...@intel.com; liming@intel.com > > Subject: [

Re: [edk2] [PATCH] MdePkg/SecPeiDxeTimerLibCpu: Consume UefiCpuPkg LAPIC code.

2017-07-23 Thread Marvin Häuser
Subject: [edk2] [PATCH] MdePkg/SecPeiDxeTimerLibCpu: Consume > UefiCpuPkg LAPIC code. > > X86TimerLib is changed to use UefiCpuPkg LAPIC register definitions and > LocalApicLib to remove duplicated code. An implicite change is the value > returned by InternalX8

[edk2] [PATCH] MdePkg/SecPeiDxeTimerLibCpu: Consume UefiCpuPkg LAPIC code.

2017-07-23 Thread Marvin Häuser
X86TimerLib is changed to use UefiCpuPkg LAPIC register definitions and LocalApicLib to remove duplicated code. An implicite change is the value returned by InternalX86GetApicBase() as it now returns the result of GetLocalApicBaseAddress(), which is the full LAPIC address. This also implicitely fix