Re: [edk2] [PATCH] OvmfPkg/BaseMemEncryptSevLib: Enable protection for newly added page table

2018-01-08 Thread Brijesh Singh
Hi Laszlo, On 01/05/2018 05:38 AM, Laszlo Ersek wrote: Hi Brijesh, (Adding Ray, based on Jian's and Ray's feedback in another branch of this thread.) This time I prefer to write a shorter email: (1) First of all, congrats on your family :) Thank you :) (2) Please file a new TianoCore

Re: [edk2] [PATCH] OvmfPkg/BaseMemEncryptSevLib: Enable protection for newly added page table

2018-01-05 Thread Laszlo Ersek
Hi Brijesh, (Adding Ray, based on Jian's and Ray's feedback in another branch of this thread.) This time I prefer to write a shorter email: (1) First of all, congrats on your family :) (2) Please file a new TianoCore BZ: - for UefiCpuPkg (for the time being), - with the title "create page

Re: [edk2] [PATCH] OvmfPkg/BaseMemEncryptSevLib: Enable protection for newly added page table

2018-01-04 Thread Ni, Ruiyu
On 1/5/2018 9:10 AM, Wang, Jian J wrote: Add Cc to Ruiyu, who has plan to consolidate page table manipulation method. He may want to share more information. Yes I do have a plan to create a page table library to abstract all page table manipulations. I will share more details in a separate

Re: [edk2] [PATCH] OvmfPkg/BaseMemEncryptSevLib: Enable protection for newly added page table

2018-01-04 Thread Wang, Jian J
Add Cc to Ruiyu, who has plan to consolidate page table manipulation method. He may want to share more information. Regards, Jian > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Friday, January 05, 2018 3:07 AM > To: Brijesh Singh ;

Re: [edk2] [PATCH] OvmfPkg/BaseMemEncryptSevLib: Enable protection for newly added page table

2018-01-04 Thread Brijesh Singh
Hi Laszlo, On 01/04/2018 01:07 PM, Laszlo Ersek wrote: meta comment: please also CC Ard on OvmfPkg patches; he too co-maintains OvmfPkg. I will keep that in mind and include Ard on all OvmfPkg patches. The following line is missing, from above your S-o-b: Contributed-under: TianoCore

Re: [edk2] [PATCH] OvmfPkg/BaseMemEncryptSevLib: Enable protection for newly added page table

2018-01-04 Thread Laszlo Ersek
Hi Brijesh, meta comment: please also CC Ard on OvmfPkg patches; he too co-maintains OvmfPkg. More below: On 01/04/18 18:06, Brijesh Singh wrote: > Commit 2ac1730bf2a5 (MdeModulePkg/DxeIpl: Mark page table as read-only) > sets the memory pages used for page table as read-only after paging is >

[edk2] [PATCH] OvmfPkg/BaseMemEncryptSevLib: Enable protection for newly added page table

2018-01-04 Thread Brijesh Singh
Commit 2ac1730bf2a5 (MdeModulePkg/DxeIpl: Mark page table as read-only) sets the memory pages used for page table as read-only after paging is setup and sets CR0.WP to protect CPU modifying the read-only pages. The commit causes #PF when MemEncryptSevClearPageEncMask() or