Re: [edk2] [PATCH] OvmfPkg/QemuVideoDxe: handle invalid BltOperation gracefully

2018-03-26 Thread Laszlo Ersek
On 03/26/18 03:26, Ni, Ruiyu wrote: > On 3/24/2018 11:52 AM, Ard Biesheuvel wrote: >> On 23 March 2018 at 21:57, Laszlo Ersek wrote: >>> According to the UEFI spec, EFI_GRAPHICS_OUTPUT_PROTOCOL.Blt() is >>> supposed >>> to catch an invalid BltOperation, and report it with >>> EFI_INVALID_PARAMETER

Re: [edk2] [PATCH] OvmfPkg/QemuVideoDxe: handle invalid BltOperation gracefully

2018-03-25 Thread Ni, Ruiyu
On 3/24/2018 11:52 AM, Ard Biesheuvel wrote: On 23 March 2018 at 21:57, Laszlo Ersek wrote: According to the UEFI spec, EFI_GRAPHICS_OUTPUT_PROTOCOL.Blt() is supposed to catch an invalid BltOperation, and report it with EFI_INVALID_PARAMETER. Remove the assertion from QemuVideoGraphicsOutputBl

Re: [edk2] [PATCH] OvmfPkg/QemuVideoDxe: handle invalid BltOperation gracefully

2018-03-23 Thread Ard Biesheuvel
On 23 March 2018 at 21:57, Laszlo Ersek wrote: > According to the UEFI spec, EFI_GRAPHICS_OUTPUT_PROTOCOL.Blt() is supposed > to catch an invalid BltOperation, and report it with > EFI_INVALID_PARAMETER. > > Remove the assertion from QemuVideoGraphicsOutputBlt() that prevents this > from working i

[edk2] [PATCH] OvmfPkg/QemuVideoDxe: handle invalid BltOperation gracefully

2018-03-23 Thread Laszlo Ersek
According to the UEFI spec, EFI_GRAPHICS_OUTPUT_PROTOCOL.Blt() is supposed to catch an invalid BltOperation, and report it with EFI_INVALID_PARAMETER. Remove the assertion from QemuVideoGraphicsOutputBlt() that prevents this from working in NOOPT and DEBUG builds. Cc: Ard Biesheuvel Cc: Rocky C