Star,
Thanks for the comments.
I will take #1.
For #2, I prefer to remove the macro😊
Thanks/Ray
> -Original Message-
> From: Zeng, Star
> Sent: Friday, May 25, 2018 5:06 PM
> To: Ni, Ruiyu ; edk2-devel@lists.01.org
> Cc: Zeng, Star
> Subject: RE: [PATCH] PcAtChipsetPkg/PcRtc: Add two new
Two minor comments:
1. PcAtChipsetPkg.uni also needs to be updated for the new PCDs.
2. Update all the places of the two macros, or just update like below? Just for
you to consider. :) I do not insist.
#define PCAT_RTC_ADDRESS_REGISTER PcdGet8 (PcdRtcIndexRegister)
#define PCAT_RTC_DATA_REGISTE
In certain HW implementation, the BIT7 of RTC Index register(0x70) is
for NMI sources enable/disable but the BIT7 of 0x70 cannot be read
before writing. Software which doesn't want to change the NMI sources
enable/disable setting can write to the alias register 0x74, through
which only BIT0 ~ BIT6
3 matches
Mail list logo