Re: [edk2] [PATCH] SecurityPkg: Support PP version lower than 1.3

2018-02-05 Thread Zhang, Chao B
Qin & Jiewen Tks for your comments , I will follow up to update the patch. -Original Message- From: Yao, Jiewen Sent: Tuesday, February 6, 2018 10:33 AM To: Long, Qin ; Zhang, Chao B ; edk2-devel@lists.01.org Subject: RE: [PATCH] SecurityPkg:

Re: [edk2] [PATCH] SecurityPkg: Support PP version lower than 1.3

2018-02-05 Thread Yao, Jiewen
Yeah. I suggest we just use sizeof() for the fixed string. > -Original Message- > From: Long, Qin > Sent: Tuesday, February 6, 2018 10:30 AM > To: Zhang, Chao B ; edk2-devel@lists.01.org > Cc: Yao, Jiewen > Subject: RE: [PATCH] SecurityPkg:

Re: [edk2] [PATCH] SecurityPkg: Support PP version lower than 1.3

2018-02-05 Thread Long, Qin
Could you update the AsciiStrLen usage with safe version, or direct "sizeof()"? Others looks good to me. Reviewed-by: Long Qin Best Regards & Thanks, LONG, Qin -Original Message- From: Zhang, Chao B Sent: Monday, February 5, 2018 10:32 AM To:

[edk2] [PATCH] SecurityPkg: Support PP version lower than 1.3

2018-02-04 Thread Zhang, Chao B
TCG PP 1.2 & PP 1.3 spec defined different Opcodes. Update code to support both. Cc: Long Qin Cc: Yao Jiewen Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Chao Zhang --- .../SmmTcg2PhysicalPresenceLib.c