Re: [edk2] [PATCH] ShellPkg/[hex]edit: use SimpleTextInEx to read console

2018-05-31 Thread Ni, Ruiyu
> enter. > > Can you have a look at this? I assume any shell binary built with this > change will > have a similar issue. > > Thanks, > Jim > > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ruiyu > Ni > Sent: Mo

Re: [edk2] [PATCH] ShellPkg/[hex]edit: use SimpleTextInEx to read console

2018-05-22 Thread Jim.Dailey
able to enter. Can you have a look at this? I assume any shell binary built with this change will have a similar issue. Thanks, Jim -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ruiyu Ni Sent: Monday, February 12, 2018 9:34 AM To: edk2-devel@lists.

Re: [edk2] [PATCH] ShellPkg/[hex]edit: use SimpleTextInEx to read console

2018-02-12 Thread Carsey, Jaben
Reviewed-by: Jaben Carsey > -Original Message- > From: Ni, Ruiyu > Sent: Monday, February 12, 2018 7:34 AM > To: edk2-devel@lists.01.org > Cc: Felix ; Carsey, Jaben > Subject: [PATCH] ShellPkg/[hex]edit: use SimpleTextInEx

[edk2] [PATCH] ShellPkg/[hex]edit: use SimpleTextInEx to read console

2018-02-12 Thread Ruiyu Ni
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=682 Edit and HexEdit commands assume that SimpleTxtIn translates Ctrl+ key combinations into Unicode control characters (0x1-0x1A). Such translation does not seem to be required by the UEFI spec. Shell should not rely on implementation specific