Re: [edk2] [PATCH] ShellPkg/Shell: Check the OpenVolume result in OpenRootByHandle()

Reviewed-by: Ruiyu Ni Thanks/Ray > -Original Message- > From: Wu, Hao A > Sent: Tuesday, November 14, 2017 4:41 PM > To: Ni, Ruiyu ; edk2-devel@lists.01.org > Cc: Carsey, Jaben > Subject: RE: [PATCH] ShellPkg/Shell: Check

Re: [edk2] [PATCH] ShellPkg/Shell: Check the OpenVolume result in OpenRootByHandle()

> -Original Message- > From: Ni, Ruiyu > Sent: Tuesday, November 14, 2017 4:38 PM > To: Wu, Hao A; edk2-devel@lists.01.org > Cc: Carsey, Jaben > Subject: RE: [PATCH] ShellPkg/Shell: Check the OpenVolume result in > OpenRootByHandle() > > How about changing the function header comments

Re: [edk2] [PATCH] ShellPkg/Shell: Check the OpenVolume result in OpenRootByHandle()

How about changing the function header comments from > + @retval EFI_MEDIA_CHANGED The device has a different medium in it or > the medium is no longer supported. To: > + @retval others Error status returned from > EFI_SIMPLE_FILE_SYSTEM_PROTOCOL->OpenVolume(). Because MEDIA_CHANGED is

[edk2] [PATCH] ShellPkg/Shell: Check the OpenVolume result in OpenRootByHandle()

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=779 For the API EfiShellOpenRootByHandle(): The return status of the call to SimpleFileSystem->OpenVolume should be checked. It is possible that there is a media change in the device (like CD/DVD ROM). In such case, the volume root opened