Re: [edk2] [PATCH] ShellPkg: Expand special output file to include "NULL" and case insensitive

2016-09-22 Thread Carsey, Jaben
Reviewed-by: Jaben Carsey And commited. > -Original Message- > From: Tapan Shah [mailto:tapands...@hpe.com] > Sent: Thursday, September 22, 2016 12:13 PM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben ; Tapan Shah > > Subject: [PATCH] ShellPkg: Expand special output file to include "N

[edk2] [PATCH] ShellPkg: Expand special output file to include "NULL" and case insensitive

2016-09-22 Thread Tapan Shah
As per ECR 1349 change in UEFI Shell Specification 2.2, expanding a special output file name to include "NULL". Previously it only supported "NUL" as a special output file and it was case sensitive. With this change both "NUL" and "NULL" are special output file and checked as case insensitive. Con

Re: [edk2] [PATCH] ShellPkg: Expand special output file to include "NULL" and case insensitive

2016-09-22 Thread Carsey, Jaben
Tapan, I do not think we should tie UefiShellLib into UefiShellCommandLib. The problem is that UefiShellLib is for internal commands, the shell itself, and shell applications. The UefiShellCommandLib is only for internal commands. What amount of work would it take to keep these libraries sep

[edk2] [PATCH] ShellPkg: Expand special output file to include "NULL" and case insensitive

2016-09-22 Thread Tapan Shah
As per ECR 1349 change in UEFI Shell Specification 2.2, expanding a special output file name to include "NULL". Previously it only supported "NUL" as a special output file and it was case sensitive. With this change both "NUL" and "NULL" are special output file and checked as case insensitive. Con