Re: [edk2] [PATCH] ShellPkg: Fix the ASSERT issue in Shell 'for' loop

On 07/22/15 09:41, Qiu Shumin wrote: > The 3rd parameter of 'GetNextParameter' is the buffer size in bytes. While > StrnCpys requires user to pass the max number of dest unicode char, we should > convert size in bytes to the number of char. > > Cc: Jaben Carsey > Contributed-under: TianoCore Co

Re: [edk2] [PATCH] ShellPkg: Fix the ASSERT issue in Shell 'for' loop

Can you update the comment to just say "Length" instead of "The 3rd parameter of 'GetNextParameter'"... the variable name is visible in the change, the 3rd parameter of a function is not. Reviewed-by: Jaben Carsey > -Original Message- > From: Qiu, Shumin > Sent: Wednesday, July 22, 201

[edk2] [PATCH] ShellPkg: Fix the ASSERT issue in Shell 'for' loop

The 3rd parameter of 'GetNextParameter' is the buffer size in bytes. While StrnCpys requires user to pass the max number of dest unicode char, we should convert size in bytes to the number of char. Cc: Jaben Carsey Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Qiu Shumi