Re: [edk2] [PATCH] ShellPkg: Mark InvalidCharacters[] in Shell.c as unused

2018-09-26 Thread Tomas Pilar (tpilar)
Thanks, I'll respin. On 26/09/18 05:54, Ni, Ruiyu wrote: > On 9/25/2018 10:50 PM, Carsey, Jaben wrote: >> I would prefer we just delete this. >> >> Ray, >> What do you think? >> > Not sure I sent it or not. > I also prefer to delete it. Git history can help in future if we need it > again. _

Re: [edk2] [PATCH] ShellPkg: Mark InvalidCharacters[] in Shell.c as unused

2018-09-25 Thread Ni, Ruiyu
On 9/25/2018 10:50 PM, Carsey, Jaben wrote: I would prefer we just delete this. Ray, What do you think? Not sure I sent it or not. I also prefer to delete it. Git history can help in future if we need it again. ___ edk2-devel mailing list edk2-deve

Re: [edk2] [PATCH] ShellPkg: Mark InvalidCharacters[] in Shell.c as unused

2018-09-25 Thread Ni, Ruiyu
ar (tpilar) > > Sent: Tuesday, September 25, 2018 3:15 AM > > To: edk2-devel@lists.01.org > > Subject: [edk2] [PATCH] ShellPkg: Mark InvalidCharacters[] in Shell.c > > as unused > > Importance: High > > > > This fixes unused const variable gcc 7.3 compilati

Re: [edk2] [PATCH] ShellPkg: Mark InvalidCharacters[] in Shell.c as unused

2018-09-25 Thread Carsey, Jaben
] [PATCH] ShellPkg: Mark InvalidCharacters[] in Shell.c as > unused > Importance: High > > This fixes unused const variable gcc 7.3 compilation error. Array is not > simply removed as the list of invalid characters might be salient > in future and for easy documentatio

[edk2] [PATCH] ShellPkg: Mark InvalidCharacters[] in Shell.c as unused

2018-09-25 Thread Tomas Pilar (tpilar)
This fixes unused const variable gcc 7.3 compilation error. Array is not simply removed as the list of invalid characters might be salient in future and for easy documentation. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Tomas Pilar --- ShellPkg/Application/Shell/Shell