Re: [edk2] [PATCH] UefiCpuPkg/CpuDxe: Fix assert issue on IA32 platform

2017-09-29 Thread Wang, Jian J
Mike, Thanks for the feedback. I'll update the patch as what you suggested. And if no more other comments, I'll check in the updated one today (or tonight). Jian > -Original Message- > From: Kinney, Michael D > Sent: Saturday, September 30, 2017 12:27 AM > To: Wang, Jian J ; edk2-devel@

Re: [edk2] [PATCH] UefiCpuPkg/CpuDxe: Fix assert issue on IA32 platform

2017-09-29 Thread Kinney, Michael D
Jian, The names of the functions do not look right to me. I think the checks being made check to see if paging is enabled. Also, the check being made is to see if both paging is enabled and page address extensions is enabled. If you use the IA32_CR0 and IA32_CR4 structures from BaseLib.h, the

Re: [edk2] [PATCH] UefiCpuPkg/CpuDxe: Fix assert issue on IA32 platform

2017-09-28 Thread Zeng, Star
: Fix assert issue on IA32 platform This patch is to fix an assert issue during booting IA32 platforms such as OvmfIa32 or Quark. This issue is caused by trying to access page table on a platform without page table. A check is added to avoid the assert. Bug tracker: https://bugzilla.tianocore.org

[edk2] [PATCH] UefiCpuPkg/CpuDxe: Fix assert issue on IA32 platform

2017-09-28 Thread Jian J Wang
This patch is to fix an assert issue during booting IA32 platforms such as OvmfIa32 or Quark. This issue is caused by trying to access page table on a platform without page table. A check is added to avoid the assert. Bug tracker: https://bugzilla.tianocore.org/show_bug.cgi?id=724 c: Star Zeng C