Re: [edk2] [PATCH] UefiCpuPkg/CpuDxe: Fix multiple entries of RT_CODE in memory map

2017-11-09 Thread Wang, Jian J
; Cc: Laszlo Ersek ; Yao, Jiewen ; > Dong, Eric > Subject: [edk2] [PATCH] UefiCpuPkg/CpuDxe: Fix multiple entries of RT_CODE in > memory map > > > v5: > >Coding style clean-up > > > v4: > > a. Remove DoUpdate and check attributes mismatch all the time t

[edk2] [PATCH] UefiCpuPkg/CpuDxe: Fix multiple entries of RT_CODE in memory map

2017-11-09 Thread Jian J Wang
> v5: >Coding style clean-up > v4: > a. Remove DoUpdate and check attributes mismatch all the time to avoid >a logic hole > b. Add warning message if failed to update capability > c. Add local variable to hold new attributes to make code cleaner > v3: > a. Add comment to explain more on u

Re: [edk2] [PATCH] UefiCpuPkg/CpuDxe: Fix multiple entries of RT_CODE in memory map

2017-10-26 Thread Wang, Jian J
Hi Laszlo, > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Thursday, October 26, 2017 6:08 PM > To: Wang, Jian J ; edk2-devel@lists.01.org > Cc: Yao, Jiewen ; Dong, Eric > Subject: Re: [edk2] [PATCH] UefiCpuPkg/CpuDxe: Fix multiple entri

Re: [edk2] [PATCH] UefiCpuPkg/CpuDxe: Fix multiple entries of RT_CODE in memory map

2017-10-26 Thread Laszlo Ersek
Hello Jian, On 10/23/17 08:50, Jian J Wang wrote: > More than one entry of RT_CODE memory might cause boot problem for some > old OSs. This patch will fix this issue to keep OS compatibility as much > as possible. > > Cc: Eric Dong > Cc: Jiewen Yao > Contributed-under: TianoCore Contribution Agr

Re: [edk2] [PATCH] UefiCpuPkg/CpuDxe: Fix multiple entries of RT_CODE in memory map

2017-10-26 Thread Laszlo Ersek
Yao, Jiewen ; Dong, Eric >> Subject: Re: [edk2] [PATCH] UefiCpuPkg/CpuDxe: Fix multiple entries of >> RT_CODE in memory map >> >> On 10/25/17 03:33, Wang, Jian J wrote: >>> Hi Laszlo, >>> >>> Thanks for the feedback. I'd like to explain a bi

Re: [edk2] [PATCH] UefiCpuPkg/CpuDxe: Fix multiple entries of RT_CODE in memory map

2017-10-25 Thread Wang, Jian J
gt; output or the behavior will show the difference. > PcdImageProtectionPolicy is enabled by default. It can be "naturally" reproduced. > Thanks! > Laszlo > > > >> -Original Message- > >> From: Laszlo Ersek [mailto:ler...@redhat.com] >

Re: [edk2] [PATCH] UefiCpuPkg/CpuDxe: Fix multiple entries of RT_CODE in memory map

2017-10-25 Thread Laszlo Ersek
e kind of "reproducer" would be really nice -- steps that you can run both with and without this patch, and the output or the behavior will show the difference. Thanks! Laszlo >> -Original Message----- >> From: Laszlo Ersek [mailto:ler...@redhat.com] >> Sent: Tuesday

Re: [edk2] [PATCH] UefiCpuPkg/CpuDxe: Fix multiple entries of RT_CODE in memory map

2017-10-24 Thread Wang, Jian J
, 2017 8:20 PM > To: Wang, Jian J ; edk2-devel@lists.01.org > Cc: Yao, Jiewen ; Dong, Eric > Subject: Re: [edk2] [PATCH] UefiCpuPkg/CpuDxe: Fix multiple entries of > RT_CODE in memory map > > On 10/23/17 08:50, Jian J Wang wrote: > > More than one entry of RT_CODE memo

Re: [edk2] [PATCH] UefiCpuPkg/CpuDxe: Fix multiple entries of RT_CODE in memory map

2017-10-24 Thread Laszlo Ersek
On 10/23/17 08:50, Jian J Wang wrote: > More than one entry of RT_CODE memory might cause boot problem for some > old OSs. This patch will fix this issue to keep OS compatibility as much > as possible. > > Cc: Eric Dong > Cc: Jiewen Yao > Contributed-under: TianoCore Contribution Agreement 1.1 >

[edk2] [PATCH] UefiCpuPkg/CpuDxe: Fix multiple entries of RT_CODE in memory map

2017-10-22 Thread Jian J Wang
More than one entry of RT_CODE memory might cause boot problem for some old OSs. This patch will fix this issue to keep OS compatibility as much as possible. Cc: Eric Dong Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jian J Wang --- UefiCpuPkg/CpuDxe/Cp