t: Re: [edk2] [PATCH] UefiCpuPkg/CpuMpPei: fix unsafe way to get stack
> pointer
>
> On 09/26/18 04:18, Wang, Jian J wrote:
> > Hi,
> >
> > Since the patch will introduce "#if defined(...)" macro in code, which
> > violates
> > edk2 coding style, it
zlo Ersek [mailto:ler...@redhat.com]
>> Sent: Wednesday, September 19, 2018 7:17 PM
>> To: Justen, Jordan L ; Wang, Jian J
>> ; edk2-devel@lists.01.org
>> Cc: Wu, Hao A ; Bi, Dandan ;
>> Dong, Eric ; Kinney, Michael D
>>
>> Subject: Re: [edk2] [PATCH] U
g, Eric ; Kinney, Michael D
>
> Subject: Re: [edk2] [PATCH] UefiCpuPkg/CpuMpPei: fix unsafe way to get stack
> pointer
>
> On 09/18/18 20:02, Jordan Justen wrote:
> > I guess the git config sendemail.from setting did not help your
> > patches. ?? It still is coming through
On 09/18/18 20:02, Jordan Justen wrote:
> I guess the git config sendemail.from setting did not help your
> patches. ?? It still is coming through with a From field of
> .
>
> Regarding this patch, I suppose it is worth asking if &StackBase in
> the old code could possibly be an address not on the
> -Original Message-
> From: Wang, Jian J
> Sent: Wednesday, September 19, 2018 9:13 AM
> To: Justen, Jordan L; edk2-devel@lists.01.org
> Cc: Wu, Hao A; Bi, Dandan; Laszlo Ersek; Dong, Eric; Kinney, Michael D
> Subject: RE: [edk2] [PATCH] UefiCpuPkg/CpuMpPei: fix unsaf
devel@lists.01.org
> Cc: Wu, Hao A ; Bi, Dandan ;
> Laszlo Ersek ; Dong, Eric ; Kinney,
> Michael D
> Subject: Re: [edk2] [PATCH] UefiCpuPkg/CpuMpPei: fix unsafe way to get stack
> pointer
>
> I guess the git config sendemail.from setting did not help your
> patches. ?? It sti
I know the rule. But I saw it used in CpuDxe/CpuGdt.h and I thought it could
have exceptions. Anyway, I agree keeping consistency is more important.
Regards,
Jian
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Wednesday, September 19, 2018 12:42 AM
> To: Wan
I guess the git config sendemail.from setting did not help your
patches. ?? It still is coming through with a From field of
.
Regarding this patch, I suppose it is worth asking if &StackBase in
the old code could possibly be an address not on the stack. I don't
think it is possible, and I'm guessi
Adding Jordan, Ard, Liming, Mike; comment at the bottom:
On 09/18/18 11:04, Jian J Wang wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1186
>
> This patch uses SetJump() to get the stack pointer from esp/rsp
> register to replace local variable way, which was marked by static
> code
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1186
This patch uses SetJump() to get the stack pointer from esp/rsp
register to replace local variable way, which was marked by static
code checker as an unsafe way.
Cc: Dandan Bi
Cc: Hao A Wu
Cc: Eric Dong
Cc: Laszlo Ersek
Contributed-unde
10 matches
Mail list logo
