Re: [edk2] [PATCH] UefiCpuPkg/MpInitLib: fix issue in wakeup buffer initialization

2018-01-24 Thread Wang, Jian J
Considering that there's a similar assignment in "else" block ExchangeInfo->ModeTransitionMemory = (UINT32) (ExchangeInfo->BufferStart + CpuMpData->AddressMap.ModeTransitionOffset); I would rather keep the assignment statement you mentioned inside "if" block. Actually there's another

Re: [edk2] [PATCH] UefiCpuPkg/MpInitLib: fix issue in wakeup buffer initialization

2018-01-24 Thread Laszlo Ersek
On 01/24/18 03:08, Jian J Wang wrote: > To fix an issue in which enabling NX feature will mark the AP wakeup > buffer as non-executable and fail the AP init, the buffer was split > into two part: the lower part in memory within 1MB and the higher part > within allocated executable memory

[edk2] [PATCH] UefiCpuPkg/MpInitLib: fix issue in wakeup buffer initialization

2018-01-23 Thread Jian J Wang
To fix an issue in which enabling NX feature will mark the AP wakeup buffer as non-executable and fail the AP init, the buffer was split into two part: the lower part in memory within 1MB and the higher part within allocated executable memory (EfiBootServicesCode). But the address of higher part