Re: [edk2] [PATCH] UefiCpuPkg/MpInitLib: fix wrong base address set as Stack Guard

2018-01-04 Thread Wang, Jian J
devel@lists.01.org Cc: Dong, Eric <eric.d...@intel.com> Subject: 答复: [edk2] [PATCH] UefiCpuPkg/MpInitLib: fix wrong base address set as Stack Guard Cool. PI SCT is better and easier. Jeff 发件人: Yao, Jiewen<mailto:jiewen@intel.com> 发送时间: 2018年1月5日 10:58 收件人: Wang, Jian J<mailto:

Re: [edk2] [PATCH] UefiCpuPkg/MpInitLib: fix wrong base address set as Stack Guard

2018-01-04 Thread Yao, Jiewen
om>; Dong, Eric <eric.d...@intel.com> Subject: RE: [edk2] [PATCH] UefiCpuPkg/MpInitLib: fix wrong base address set as Stack Guard Got it. Many thanks! Regards, Jian From: Fan Jeff [mailto:vanjeff_...@hotmail.com] Sent: Friday, January 05, 2018 10:50 AM To: Wang, Jian J <jian.j.w..

Re: [edk2] [PATCH] UefiCpuPkg/MpInitLib: fix wrong base address set as Stack Guard

2018-01-04 Thread Wang, Jian J
t;eric.d...@intel.com> Subject: 答复: [edk2] [PATCH] UefiCpuPkg/MpInitLib: fix wrong base address set as Stack Guard Sorry, Dump the APICID, not CPUID. Jeff 发件人: Fan Jeff<mailto:vanjeff_...@hotmail.com> 发送时间: 2018年1月5日 10:48 收件人: Wang, Jian J<mailto:jian.j.w...@intel.com>; Laszlo Er

Re: [edk2] [PATCH] UefiCpuPkg/MpInitLib: fix wrong base address set as Stack Guard

2018-01-04 Thread Wang, Jian J
.org Cc: Yao, Jiewen <jiewen@intel.com>; Dong, Eric <eric.d...@intel.com> Subject: 答复: [edk2] [PATCH] UefiCpuPkg/MpInitLib: fix wrong base address set as Stack Guard Laszlo, Firstly, SwitchBSP() is one service of MP defined in PI spec. For real case, I think multiple socket system(

Re: [edk2] [PATCH] UefiCpuPkg/MpInitLib: fix wrong base address set as Stack Guard

2018-01-04 Thread Wang, Jian J
com>; Dong, Eric <eric.d...@intel.com> > Subject: Re: [edk2] [PATCH] UefiCpuPkg/MpInitLib: fix wrong base address set > as Stack Guard > > On 01/04/18 02:45, Wang, Jian J wrote: > > A correction: although BSP doesn't need it, we still need to initialize its > ApTopOfStack > &g

Re: [edk2] [PATCH] UefiCpuPkg/MpInitLib: fix wrong base address set as Stack Guard

2018-01-04 Thread Laszlo Ersek
ts.01.org >> Cc: Yao, Jiewen <jiewen@intel.com>; Dong, Eric <eric.d...@intel.com> >> Subject: RE: [edk2] [PATCH] UefiCpuPkg/MpInitLib: fix wrong base address set >> as Stack Guard >> >> Laszlo, >> >> More explanations: >> >> [UefiCp

Re: [edk2] [PATCH] UefiCpuPkg/MpInitLib: fix wrong base address set as Stack Guard

2018-01-04 Thread Laszlo Ersek
>> To: Laszlo Ersek <ler...@redhat.com>; edk2-devel@lists.01.org >> Cc: Yao, Jiewen <jiewen....@intel.com>; Dong, Eric <eric.d...@intel.com> >> Subject: Re: [edk2] [PATCH] UefiCpuPkg/MpInitLib: fix wrong base address set >> as Stack Guard >

Re: [edk2] [PATCH] UefiCpuPkg/MpInitLib: fix wrong base address set as Stack Guard

2018-01-03 Thread Wang, Jian J
c: Yao, Jiewen <jiewen@intel.com>; Dong, Eric <eric.d...@intel.com> > Subject: RE: [edk2] [PATCH] UefiCpuPkg/MpInitLib: fix wrong base address set > as Stack Guard > > Laszlo, > > More explanations: > > [UefiCpuPkg\Library\MpInitLib\MpLib.c] > Acc

Re: [edk2] [PATCH] UefiCpuPkg/MpInitLib: fix wrong base address set as Stack Guard

2018-01-03 Thread Wang, Jian J
f Wang, > Jian J > Sent: Thursday, January 04, 2018 8:42 AM > To: Laszlo Ersek <ler...@redhat.com>; edk2-devel@lists.01.org > Cc: Yao, Jiewen <jiewen@intel.com>; Dong, Eric <eric.d...@intel.com> > Subject: Re: [edk2] [PATCH] UefiCpuPkg/MpInitLib: fix wrong base a

Re: [edk2] [PATCH] UefiCpuPkg/MpInitLib: fix wrong base address set as Stack Guard

2018-01-03 Thread Wang, Jian J
.com>; > Jeff Fan <vanjeff_...@hotmail.com> > Subject: Re: [edk2] [PATCH] UefiCpuPkg/MpInitLib: fix wrong base address set > as Stack Guard > > (CC Jeff) > > Sorry about the delay. > > I have some light comments below; I expect at least a few of them to be > i

Re: [edk2] [PATCH] UefiCpuPkg/MpInitLib: fix wrong base address set as Stack Guard

2018-01-03 Thread Laszlo Ersek
(CC Jeff) Sorry about the delay. I have some light comments below; I expect at least a few of them to be incorrect :) On 12/29/17 09:36, Jian J Wang wrote: > The reason is that DXE part initialization will reuse the stack allocated > at PEI phase, if MP was initialized before. Some code added

Re: [edk2] [PATCH] UefiCpuPkg/MpInitLib: fix wrong base address set as Stack Guard

2018-01-02 Thread Wang, Jian J
r...@redhat.com>; Yao, Jiewen <jiewen@intel.com>; > Dong, Eric <eric.d...@intel.com> > Subject: [edk2] [PATCH] UefiCpuPkg/MpInitLib: fix wrong base address set as > Stack Guard > > The reason is that DXE part initialization will reuse the stack allocated > at PE

[edk2] [PATCH] UefiCpuPkg/MpInitLib: fix wrong base address set as Stack Guard

2017-12-29 Thread Jian J Wang
The reason is that DXE part initialization will reuse the stack allocated at PEI phase, if MP was initialized before. Some code added to check this situation and use stack base address saved in HOB passed from PEI. Cc: Jiewen Yao Cc: Eric Dong Cc: