Re: [edk2] [PATCH 0/3] BaseTools GCC: pass CC flags to linker

2016-08-03 Thread Ard Biesheuvel
On 3 August 2016 at 15:20, Gao, Liming wrote: > Ard: > > Thanks for your detail explain. I understand it. I add my rb for this > patch set. > > > > Reviewed-by: Liming Gao > Pushed as 108c5b601860 BaseTools GCC: move -c compiler flag to build rules f8d0b9662993 BaseTools GCC5: disable warning

Re: [edk2] [PATCH 0/3] BaseTools GCC: pass CC flags to linker

2016-08-03 Thread Gao, Liming
Ard: Thanks for your detail explain. I understand it. I add my rb for this patch set. Reviewed-by: Liming Gao mailto:liming@intel.com>> Thanks Liming From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] Sent: Wednesday, August 3, 2016 5:24 PM To: Gao, Liming Cc: Zhu, Yonghong ; Justen

Re: [edk2] [PATCH 0/3] BaseTools GCC: pass CC flags to linker

2016-08-03 Thread Ard Biesheuvel
On 3 August 2016 at 10:58, Gao, Liming wrote: > Ard: > I see Steven says it doesn't work, yet. So, I am curious what real issue is > resolved by this patch? > For example, when building ArmVirtQemu for ARM, you may get warnings (or errors when -Werror is enabled) like lto1: warning: switch -m

Re: [edk2] [PATCH 0/3] BaseTools GCC: pass CC flags to linker

2016-08-03 Thread Gao, Liming
Ard: I see Steven says it doesn't work, yet. So, I am curious what real issue is resolved by this patch? Thanks Liming > -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Wednesday, August 03, 2016 4:23 PM > To: Gao, Liming > Cc: Zhu, Yonghong ; Juste

Re: [edk2] [PATCH 0/3] BaseTools GCC: pass CC flags to linker

2016-08-03 Thread Ard Biesheuvel
On 2 August 2016 at 16:51, Ard Biesheuvel wrote: > On 2 August 2016 at 16:50, Gao, Liming wrote: >> Ard: >> Without this change, GCC5 LTO can pass build. With it, what difference >> will be in the generated image? Original way may generate the wrong image, >> or new way will generate the smal

Re: [edk2] [PATCH 0/3] BaseTools GCC: pass CC flags to linker

2016-08-02 Thread Ard Biesheuvel
On 2 August 2016 at 16:50, Gao, Liming wrote: > Ard: > Without this change, GCC5 LTO can pass build. With it, what difference will > be in the generated image? Original way may generate the wrong image, or new > way will generate the smaller image? > This is not about code size but about corr

Re: [edk2] [PATCH 0/3] BaseTools GCC: pass CC flags to linker

2016-08-02 Thread Gao, Liming
Ard: Without this change, GCC5 LTO can pass build. With it, what difference will be in the generated image? Original way may generate the wrong image, or new way will generate the smaller image? Thanks Liming -Original Message- From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]

[edk2] [PATCH 0/3] BaseTools GCC: pass CC flags to linker

2016-08-02 Thread Ard Biesheuvel
GCC5 runs in LTO mode, which means it may generate code during the link stage, and this code generation should be subject to the same settings as ordinary code generation. Since we now invoke GCC as the linker, we can start passing the CC_FLAGS to the linker as well, with only minor surgery. This