Re: [edk2] [PATCH 0/4] Coding style clean-up

2017-12-27 Thread Wang, Jian J
ntel.com>; edk2-devel@lists.01.org; Kinney, > Michael D <michael.d.kin...@intel.com> > Subject: RE: [edk2] [PATCH 0/4] Coding style clean-up > > Jian, > > I think . is the correct way to list > this type of exception. Otherwise we can miss incorrect > use of that fi

Re: [edk2] [PATCH 0/4] Coding style clean-up

2017-12-27 Thread Kinney, Michael D
>; > edk2-devel@lists.01.org > Subject: RE: [edk2] [PATCH 0/4] Coding style clean-up > > Current ECC use . in exception > list to exclude those special > field name spec defined. Whenever there's a new > structure introduced with those field > names, which have been added to e

Re: [edk2] [PATCH 0/4] Coding style clean-up

2017-12-27 Thread Wang, Jian J
sts.01.org; Kinney, > Michael D <michael.d.kin...@intel.com> > Subject: RE: [edk2] [PATCH 0/4] Coding style clean-up > > Yes. Please revert. > > I am not sure I understand the ECC tool update you are suggesting. > Can you provide more details? > > Mike >

Re: [edk2] [PATCH 0/4] Coding style clean-up

2017-12-27 Thread Kinney, Michael D
- > de...@lists.01.org > Subject: RE: [edk2] [PATCH 0/4] Coding style clean-up > > Hi Mike, > > Since this patch has been checked in trunk, do you think > it should be reverted? > In addition, instead of using exception list for the ECC > tool, I think it'd be better >

Re: [edk2] [PATCH 0/4] Coding style clean-up

2017-12-27 Thread Gao, Liming
>To: Kinney, Michael D <michael.d.kin...@intel.com>; edk2- >de...@lists.01.org >Subject: Re: [edk2] [PATCH 0/4] Coding style clean-up > >Hi Mike, > >Since this patch has been checked in trunk, do you think it should be reverted? >In addition, instead of using exception list

Re: [edk2] [PATCH 0/4] Coding style clean-up

2017-12-26 Thread Wang, Jian J
hael D <michael.d.kin...@intel.com> > Subject: RE: [edk2] [PATCH 0/4] Coding style clean-up > > Jian, > > I do not think this change should be made. > > One of the exceptions for not following the > EDK II code style is if the field names are > defined in a public spec

[edk2] [PATCH 0/4] Coding style clean-up

2017-12-24 Thread Jian J Wang
This patch series are meant for cleaning up code according to coding style requirements. Jian J Wang (4): MdePkg/BaseLib.h: Coding style clean-up MdeModulePkg/Core: Coding style clean-up UefiCpuPkg/UefiCpuPkg.uni: Add missing string definition for new PCDs UefiCpuPkg: Update code to use