Re: [edk2] [PATCH 01/17] MdeModulePkg: PciHostBridgeDxe: don't assume extended config space

2016-02-29 Thread Laszlo Ersek
On 02/28/16 08:16, Ni, Ruiyu wrote: >>> 在 2016年2月27日,下午6:17,Laszlo Ersek 写道: >> Thus, this argument comprises two parts: >> >> 1. PciHostBridgeDxe needs to use a platform dependent config space >> limit: 0xFF, 0xFFF, or something else that matches the platform's >> PciSegmentLib instance. Co

Re: [edk2] [PATCH 01/17] MdeModulePkg: PciHostBridgeDxe: don't assume extended config space

2016-02-27 Thread Ni, Ruiyu
Thanks, Ray >> 在 2016年2月27日,下午6:17,Laszlo Ersek 写道: >> >> On 02/27/16 03:13, Ni, Ruiyu wrote: >> Basically I don't agree to add a CFG space range field. >> See embedded reply in below. >> >> Regards, >> Ray >> >>> -Original Message- >>> From: Laszlo Ersek [mailto:ler...@redhat.com] >

Re: [edk2] [PATCH 01/17] MdeModulePkg: PciHostBridgeDxe: don't assume extended config space

2016-02-27 Thread Laszlo Ersek
On 02/27/16 03:13, Ni, Ruiyu wrote: > Basically I don't agree to add a CFG space range field. > See embedded reply in below. > > Regards, > Ray > >> -Original Message- >> From: Laszlo Ersek [mailto:ler...@redhat.com] >> Sent: Saturday, February 27, 2016 8:23 AM >> To: edk2-devel-01 >> Cc

Re: [edk2] [PATCH 01/17] MdeModulePkg: PciHostBridgeDxe: don't assume extended config space

2016-02-26 Thread Ni, Ruiyu
Basically I don't agree to add a CFG space range field. See embedded reply in below. Regards, Ray >-Original Message- >From: Laszlo Ersek [mailto:ler...@redhat.com] >Sent: Saturday, February 27, 2016 8:23 AM >To: edk2-devel-01 >Cc: Ni, Ruiyu ; Justen, Jordan L >; Marcel Apfelbaum >Subj

[edk2] [PATCH 01/17] MdeModulePkg: PciHostBridgeDxe: don't assume extended config space

2016-02-26 Thread Laszlo Ersek
The "PcAtChipsetPkg/PciHostBridgeDxe" driver hard-codes the [0x00..0xFF] range as valid config space offsets, in the RootBridgeIoCheckParameter() function -- see the MAX_PCI_REG_ADDRESS macro. This driver uses IO ports 0xCF8 / 0xCFC to access PCI config space. The (soon to be removed) "OvmfPkg/Pci