Re: [edk2] [PATCH 1/1] FatPkg/EnhancedFatDxe Fix Double Cluster Allocation

2018-09-12 Thread Ni, Ruiyu
Reviewed-by: Ruiyu Ni Thanks/Ray > -Original Message- > From: edk2-devel On Behalf Of > Robinson, Herbie > Sent: Friday, September 7, 2018 8:07 AM > To: edk2-devel@lists.01.org > Subject: [edk2] [PATCH 1/1] FatPkg/EnhancedFatDxe Fix Double Cluster > Allocation >

Re: [edk2] [PATCH 1/1] FatPkg/EnhancedFatDxe Fix Double Cluster Allocation

2018-09-11 Thread Laszlo Ersek
On 09/07/18 02:07, Robinson, Herbie wrote: > This is a fix for a double cluster allocation when the disk is full. The > double allocation happens because FatGrowEof calls FatAllocateCluster without > immediately marking the each returned cluster as allocated. The fix is to > move the FatSetFat

Re: [edk2] [PATCH 1/1] FatPkg/EnhancedFatDxe Fix Double Cluster Allocation

2018-09-06 Thread Robinson, Herbie
I forgot to mention this is entered as Bug 1157 in Bugzilla. Herbie Robinson Software Architect Stratus Technologies | www.stratus.com 5 Mill and Main Place, Suite 500 | Maynard, MA 01754 T: +1-978-461-7531 | E: herbie.robin...@stratus.com [Stratus Technologies]

[edk2] [PATCH 1/1] FatPkg/EnhancedFatDxe Fix Double Cluster Allocation

2018-09-06 Thread Robinson, Herbie
This is a fix for a double cluster allocation when the disk is full. The double allocation happens because FatGrowEof calls FatAllocateCluster without immediately marking the each returned cluster as allocated. The fix is to move the FatSetFatEntry call inside the loop. I've also include some