Re: [edk2] [PATCH 1/2] MdePkg/BaseLib: Add IsNodeInList() function.

Message- >> >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >> >Marvin H?user >> >Sent: Friday, July 28, 2017 12:20 AM >> >To: edk2-devel@lists.01.org >> >Cc: Kinney, Michael D <michael.d.kin...@intel.com>; Gao, Liming

Re: [edk2] [PATCH 1/2] MdePkg/BaseLib: Add IsNodeInList() function.

pty(), ASSERT() is missing for > >> InternalBaseLibIsListValid (ListHead). > > > >Sorry for these oversights. Would you prefer an internal, static > >function or a macro to do the PCD check and following the ASSERTin v2? > > > >> > >> Thanks >

Re: [edk2] [PATCH 1/2] MdePkg/BaseLib: Add IsNodeInList() function.

iginal Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >Marvin H?user >Sent: Friday, July 28, 2017 12:20 AM >To: edk2-devel@lists.01.org >Cc: Kinney, Michael D <michael.d.kin...@intel.com>; Gao, Liming ><liming....@intel.com> >Subj

Re: [edk2] [PATCH 1/2] MdePkg/BaseLib: Add IsNodeInList() function.

gt; -Original Message- > > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > > Marvin H?user > > Sent: Tuesday, July 25, 2017 12:53 AM > > To: edk2-devel@lists.01.org > > Cc: Kinney, Michael D <michael.d.kin...@intel.com> > >

Re: [edk2] [PATCH 1/2] MdePkg/BaseLib: Add IsNodeInList() function.

er > Sent: Tuesday, July 25, 2017 12:53 AM > To: edk2-devel@lists.01.org > Cc: Kinney, Michael D <michael.d.kin...@intel.com> > Subject: Re: [edk2] [PATCH 1/2] MdePkg/BaseLib: Add IsNodeInList() function. > > Hey Mike, > > In contrast to setting 'Back

Re: [edk2] [PATCH 1/2] MdePkg/BaseLib: Add IsNodeInList() function.

Hey Mike, In contrast to setting 'BackLink' and 'ForwardLink' to dummy values such as EFI_BAD_POINTER, verifying that a node is part of a known list is a safe way to determine whether a link is still valid without needing to keep the memory allocated. If the Node, which had its links set to

Re: [edk2] [PATCH 1/2] MdePkg/BaseLib: Add IsNodeInList() function.

Hi Marvin, Can you provide a few more details on why you would like to see tis internal function promoted to a library class API? Thanks, Mike > -Original Message- > From: Marvin Häuser [mailto:marvin.haeu...@outlook.com] > Sent: Sunday, July 23, 2017 3:11 AM > To:

[edk2] [PATCH 1/2] MdePkg/BaseLib: Add IsNodeInList() function.

This patch adds IsNodeInList() to BaseLib, which verifies the given Node is part of the doubly-linked List provided. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marvin Haeuser --- MdePkg/Library/BaseLib/LinkedList.c | 70