Re: [edk2] [PATCH 1/2] UefiCpuPkg/CpuDxe: allow accessing (DXE) page table in SMM mode

2018-06-12 Thread Laszlo Ersek
On 06/12/18 10:44, Wang, Jian J wrote: > Hi Laszlo, thanks for the answers, they sound OK to me. From my side, please feel free to post v2. Thanks! Laszlo ___ edk2-devel mailing list edk2-devel@lists.01.org

Re: [edk2] [PATCH 1/2] UefiCpuPkg/CpuDxe: allow accessing (DXE) page table in SMM mode

2018-06-12 Thread Laszlo Ersek
On 06/12/18 06:32, Wang, Jian J wrote: > Hi Laszlo, > > Thank you very much for such thorough review. I'd like to explain a bit in > advance. > > Putting aside the specific coding issues in my patch, one thing is clear that > SMM mode > has its own page table. CpuDxe should not touch it even

Re: [edk2] [PATCH 1/2] UefiCpuPkg/CpuDxe: allow accessing (DXE) page table in SMM mode

2018-06-12 Thread Laszlo Ersek
e- > From: Zeng, Star > Sent: Tuesday, June 12, 2018 11:35 AM > To: Laszlo Ersek ; Wang, Jian J ; > edk2-devel@lists.01.org > Cc: Ni, Ruiyu ; Yao, Jiewen ; Dong, > Eric ; Zeng, Star > Subject: RE: [edk2] [PATCH 1/2] UefiCpuPkg/CpuDxe: allow accessing (DXE) page > tab

Re: [edk2] [PATCH 1/2] UefiCpuPkg/CpuDxe: allow accessing (DXE) page table in SMM mode

2018-06-11 Thread Wang, Jian J
; From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Monday, June 11, 2018 8:18 PM > To: Wang, Jian J ; edk2-devel@lists.01.org > Cc: Ni, Ruiyu ; Yao, Jiewen ; Dong, > Eric > Subject: Re: [edk2] [PATCH 1/2] UefiCpuPkg/CpuDxe: allow accessing (DXE) > page table in SMM mode > >

Re: [edk2] [PATCH 1/2] UefiCpuPkg/CpuDxe: allow accessing (DXE) page table in SMM mode

2018-06-11 Thread Zeng, Star
ists.01.org Cc: Ni, Ruiyu ; Yao, Jiewen ; Dong, Eric ; Zeng, Star Subject: RE: [edk2] [PATCH 1/2] UefiCpuPkg/CpuDxe: allow accessing (DXE) page table in SMM mode Share some information here according to my knowledge. The EFI_SMM_BASE2_PROTOCOL.InSmm definition in PI spec is really very con

Re: [edk2] [PATCH 1/2] UefiCpuPkg/CpuDxe: allow accessing (DXE) page table in SMM mode

2018-06-11 Thread Zeng, Star
CH 1/2] UefiCpuPkg/CpuDxe: allow accessing (DXE) page table in SMM mode Hi Jian, On 06/11/18 09:08, Jian J Wang wrote: > The SMM version of MemoryAllocationLib allows to free memory allocated > in DXE (before EndOfDxe). This is done by checking the memory range > and calling gBS se

Re: [edk2] [PATCH 1/2] UefiCpuPkg/CpuDxe: allow accessing (DXE) page table in SMM mode

2018-06-11 Thread Laszlo Ersek
Hi Jian, On 06/11/18 09:08, Jian J Wang wrote: > The SMM version of MemoryAllocationLib allows to free memory allocated > in DXE (before EndOfDxe). This is done by checking the memory range and > calling gBS services to do real operation if the memory to free is out > of SMRAM. This would cause

[edk2] [PATCH 1/2] UefiCpuPkg/CpuDxe: allow accessing (DXE) page table in SMM mode

2018-06-11 Thread Jian J Wang
The SMM version of MemoryAllocationLib allows to free memory allocated in DXE (before EndOfDxe). This is done by checking the memory range and calling gBS services to do real operation if the memory to free is out of SMRAM. This would cause problem if some memory related features, like Heap Guard,