Re: [edk2] [PATCH 1/3] MdePkg: break #defines out of Uefi/UefiMultiPhase.h

2017-12-14 Thread Gao, Liming
>; Gao, Liming <liming@intel.com>; Ard Biesheuvel > <ard.biesheu...@linaro.org> > Subject: Re: [edk2] [PATCH 1/3] MdePkg: break #defines out of > Uefi/UefiMultiPhase.h > > On Thu, Dec 14, 2017 at 12:03:56PM +, Leif Lindholm wrote: > > On Thu, Dec 14, 201

Re: [edk2] [PATCH 1/3] MdePkg: break #defines out of Uefi/UefiMultiPhase.h

2017-12-14 Thread Leif Lindholm
On Thu, Dec 14, 2017 at 12:03:56PM +, Leif Lindholm wrote: > On Thu, Dec 14, 2017 at 10:44:04AM +0800, Ni, Ruiyu wrote: > > Can we just move the definitions to UefiBaseTypes.h? > > There is nothing in UefiBaseTypes.h that is fundamentally easier to > deal with than what is in UefiMultiPhase.h

Re: [edk2] [PATCH 1/3] MdePkg: break #defines out of Uefi/UefiMultiPhase.h

2017-12-14 Thread Leif Lindholm
On Thu, Dec 14, 2017 at 10:44:04AM +0800, Ni, Ruiyu wrote: > On 12/13/2017 8:26 PM, Leif Lindholm wrote: > > Turns out all .vfr files in the tree interacting with DynamicPcds > > manually copy the same set of EFI_VARIABLE_* definitions, since the rest > > of UefiMultiPhase.h is incompatible with

Re: [edk2] [PATCH 1/3] MdePkg: break #defines out of Uefi/UefiMultiPhase.h

2017-12-13 Thread Ni, Ruiyu
On 12/13/2017 8:26 PM, Leif Lindholm wrote: Turns out all .vfr files in the tree interacting with DynamicPcds manually copy the same set of EFI_VARIABLE_* definitions, since the rest of UefiMultiPhase.h is incompatible with VfrCompile. Split these out into a separate header file

[edk2] [PATCH 1/3] MdePkg: break #defines out of Uefi/UefiMultiPhase.h

2017-12-13 Thread Leif Lindholm
Turns out all .vfr files in the tree interacting with DynamicPcds manually copy the same set of EFI_VARIABLE_* definitions, since the rest of UefiMultiPhase.h is incompatible with VfrCompile. Split these out into a separate header file UefiMultiPhaseDefinitions.h in order to make it possible to