Re: [edk2] [PATCH 1/6] MdePkg UefiLib: Add new EfiFindAcpiTableBySignature() API

2018-09-05 Thread Zeng, Star
To: Yao, Jiewen ; Zeng, Star ; Kinney, Michael D Cc: edk2-devel@lists.01.org; Younas khan ; Gao, Liming Subject: RE: [edk2] [PATCH 1/6] MdePkg UefiLib: Add new EfiFindAcpiTableBySignature() API I prefer S2. Single interface is more easy for consumer to remember how to use. Thanks/Ray

Re: [edk2] [PATCH 1/6] MdePkg UefiLib: Add new EfiFindAcpiTableBySignature() API

2018-09-03 Thread Ni, Ruiyu
an ; > Gao, Liming > Subject: RE: [edk2] [PATCH 1/6] MdePkg UefiLib: Add new > EfiFindAcpiTableBySignature() API > > I prefer S1. > I believe that the EfiLocateNextAcpiTable() can also be used in S1. > > > > -Original Message- > > From: Zeng, Star > &g

Re: [edk2] [PATCH 1/6] MdePkg UefiLib: Add new EfiFindAcpiTableBySignature() API

2018-09-03 Thread Yao, Jiewen
> Gao, Liming ; Zeng, Star > Subject: RE: [edk2] [PATCH 1/6] MdePkg UefiLib: Add new > EfiFindAcpiTableBySignature() API > > Thanks. > Ok, please help and we can have good and flexible interface(s) for both > producer > and consumer. > > First, there are two cases we n

Re: [edk2] [PATCH 1/6] MdePkg UefiLib: Add new EfiFindAcpiTableBySignature() API

2018-09-03 Thread Zeng, Star
-Original Message- From: Ni, Ruiyu Sent: Monday, September 3, 2018 1:09 PM To: Zeng, Star ; Yao, Jiewen ; Kinney, Michael D Cc: edk2-devel@lists.01.org; Younas khan ; Gao, Liming Subject: RE: [edk2] [PATCH 1/6] MdePkg UefiLib: Add new EfiFindAcpiTableBySignature() API That's fine

Re: [edk2] [PATCH 1/6] MdePkg UefiLib: Add new EfiFindAcpiTableBySignature() API

2018-09-02 Thread Ni, Ruiyu
uiyu > Cc: Zeng, Star ; edk2-devel@lists.01.org; Kinney, > Michael D ; Younas khan > ; Gao, Liming > Subject: RE: [edk2] [PATCH 1/6] MdePkg UefiLib: Add new > EfiFindAcpiTableBySignature() API > > Good idea on LocateNextAcpiTable(). > > > > -Original Messag

Re: [edk2] [PATCH 1/6] MdePkg UefiLib: Add new EfiFindAcpiTableBySignature() API

2018-09-02 Thread Zeng, Star
, Star -Original Message- From: Yao, Jiewen Sent: Saturday, September 1, 2018 7:04 AM To: Ni, Ruiyu Cc: Zeng, Star ; edk2-devel@lists.01.org; Kinney, Michael D ; Younas khan ; Gao, Liming Subject: RE: [edk2] [PATCH 1/6] MdePkg UefiLib: Add new EfiFindAcpiTableBySignature() API Good

Re: [edk2] [PATCH 1/6] MdePkg UefiLib: Add new EfiFindAcpiTableBySignature() API

2018-08-31 Thread Yao, Jiewen
u > > Yao Jiewen > > > > > >> -Original Message- > >> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Star > >> Zeng > >> Sent: Friday, August 31, 2018 7:29 PM > >> To: edk2-devel@lists.01.org

Re: [edk2] [PATCH 1/6] MdePkg UefiLib: Add new EfiFindAcpiTableBySignature() API

2018-08-31 Thread Ni, Ruiyu
edk2-devel@lists.01.org >> Cc: Kinney, Michael D ; Younas khan >> ; Yao, Jiewen ; Gao, >> Liming ; Zeng, Star >> Subject: [edk2] [PATCH 1/6] MdePkg UefiLib: Add new >> EfiFindAcpiTableBySignature() API >> >> https://bugzilla.tianocore.org/show_bug.cgi?id=967 &

Re: [edk2] [PATCH 1/6] MdePkg UefiLib: Add new EfiFindAcpiTableBySignature() API

2018-08-31 Thread Ni, Ruiyu
edk2-devel@lists.01.org >> Cc: Kinney, Michael D ; Younas khan >> ; Yao, Jiewen ; Gao, >> Liming ; Zeng, Star >> Subject: [edk2] [PATCH 1/6] MdePkg UefiLib: Add new >> EfiFindAcpiTableBySignature() API >> >> https://bugzilla.tianocore.org/show_bug.cgi?id=967 &

Re: [edk2] [PATCH 1/6] MdePkg UefiLib: Add new EfiFindAcpiTableBySignature() API

2018-08-31 Thread Yao, Jiewen
2018 7:29 PM > To: edk2-devel@lists.01.org > Cc: Kinney, Michael D ; Younas khan > ; Yao, Jiewen ; Gao, > Liming ; Zeng, Star > Subject: [edk2] [PATCH 1/6] MdePkg UefiLib: Add new > EfiFindAcpiTableBySignature() API > > https://bugzilla.tianocore.org/show_bug.cgi?id=967

[edk2] [PATCH 1/6] MdePkg UefiLib: Add new EfiFindAcpiTableBySignature() API

2018-08-31 Thread Star Zeng
https://bugzilla.tianocore.org/show_bug.cgi?id=967 Request to add a library function for GetAcpiTable() in order to get ACPI table using signature as input. After evaluation, we found there are many duplicated code to find ACPI table by signature in different modules. This patch adds new