Re: [edk2] [PATCH 17/26] MdeModulePkg PiSmmCore: Remove redundant functions

2018-08-10 Thread Zeng, Star
Reviewed-by: Star Zeng -Original Message- From: Zhang, Shenglei Sent: Wednesday, August 8, 2018 4:47 PM To: edk2-devel@lists.01.org Cc: Zeng, Star ; Dong, Eric Subject: [PATCH 17/26] MdeModulePkg PiSmmCore: Remove redundant functions The functions that are never called have been remove

Re: [edk2] [PATCH 17/26] MdeModulePkg PiSmmCore: Remove redundant functions

2018-08-09 Thread Laszlo Ersek
On 08/08/18 10:47, shenglei wrote: > The functions that are never called have been removed. > They are IsImageInsideSmram,FindImageRecord,SmmRemoveImageRecord, > SmmMemoryAttributesTableConsistencyCheck,DumpSmmMemoryMapEntry, > SmmMemoryMapConsistencyCheckRange,SmmMemoryMapConsistencyCheck, > DumpS

Re: [edk2] [PATCH 17/26] MdeModulePkg PiSmmCore: Remove redundant functions

2018-08-08 Thread Wang, Jian J
el@lists.01.org> > Cc: Dong, Eric mailto:eric.d...@intel.com>>; Zeng, Star > mailto:star.z...@intel.com>> > Subject: [edk2] [PATCH 17/26] MdeModulePkg PiSmmCore: Remove > redundant functions > > The functions that are never called have been removed.

Re: [edk2] [PATCH 17/26] MdeModulePkg PiSmmCore: Remove redundant functions

2018-08-08 Thread Ni, Ruiyu
+ Wang Jian. Thanks/Ray > -Original Message- > From: edk2-devel On Behalf Of shenglei > Sent: Wednesday, August 8, 2018 4:47 PM > To: edk2-devel@lists.01.org > Cc: Dong, Eric ; Zeng, Star > Subject: [edk2] [PATCH 17/26] MdeModulePkg PiSmmCore: Remove > redunda

[edk2] [PATCH 17/26] MdeModulePkg PiSmmCore: Remove redundant functions

2018-08-08 Thread shenglei
The functions that are never called have been removed. They are IsImageInsideSmram,FindImageRecord,SmmRemoveImageRecord, SmmMemoryAttributesTableConsistencyCheck,DumpSmmMemoryMapEntry, SmmMemoryMapConsistencyCheckRange,SmmMemoryMapConsistencyCheck, DumpSmmMemoryMap,ClearGuardMapBit,SetGuardMapBit,A