Re: [edk2] [PATCH 2/2] NetworkPkg: Use Http11 definitions in HttpDxe and HttpBootDxe

2016-02-13 Thread Fu, Siyuan
Better to make a new patch, I don't know whether Liming has more comments about the patch. Siyuan From: El-Haj-Mahmoud, Samer [mailto:samer.el-haj-mahm...@hpe.com] Sent: Sunday, February 14, 2016 11:47 AM To: edk2-devel@lists.01.org; Fu, Siyuan Subject: RE: [PATCH 2/2] NetworkPkg: Use Http11 de

Re: [edk2] [PATCH 2/2] NetworkPkg: Use Http11 definitions in HttpDxe and HttpBootDxe

2016-02-13 Thread El-Haj-Mahmoud, Samer
Siyuan Either way is fine. Do you want to make the changes yourself or wait for me to submit a patch next week? -Original Message- From: Fu, Siyuan [siyuan...@intel.com] Received: Saturday, 13 Feb 2016, 8:53PM To: El-Haj-Mahmoud, Samer [samer.el-haj-mahm...@hpe.com]; edk2-devel@lists

Re: [edk2] [PATCH 2/2] NetworkPkg: Use Http11 definitions in HttpDxe and HttpBootDxe

2016-02-13 Thread Fu, Siyuan
Hi, Samer I think we'd better not to rename a defined macro in the public header file. How about we keep the macro "HTTP_VERSION" in IndustryStandard/Http11.h, and in HTTP driver we could just use this macro, or #define HTTP_VERSION_STR HTTP_VERSION Best Regards Siyuan > -Origi

[edk2] [PATCH 2/2] NetworkPkg: Use Http11 definitions in HttpDxe and HttpBootDxe

2016-02-10 Thread Samer El-Haj-Mahmoud
Change HttpDxe and HttpBootDxe to use the standard definitions from Http11.h instead of private duplicate definitions. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Samer El-Haj-Mahmoud --- NetworkPkg/HttpBootDxe/HttpBootClient.c | 7 --- NetworkPkg/HttpBootDxe/Http