Re: [edk2] [PATCH 2/2] SecurityPkg: AuthVariableLib: Add new cert database for volatile time based Auth variable

All right, the patch is good to me. Reviewed-by: Siyuan Fu -Original Message- From: Zhang, Chao B Sent: Friday, January 29, 2016 3:10 PM To: Fu, Siyuan ; edk2-de...@ml01.01.org Cc: Zeng, Star Subject: RE: [PATCH 2/2]

[edk2] [PATCH 2/2] SecurityPkg: AuthVariableLib: Add new cert database for volatile time based Auth variable

Add a new cert data base "certdbv" to store signer certs for volatile time based Auth variable. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Chao Zhang --- SecurityPkg/Library/AuthVariableLib/AuthService.c | 144 ++---

Re: [edk2] [PATCH 2/2] SecurityPkg: AuthVariableLib: Add new cert database for volatile time based Auth variable

Hi, Chao The changes for CleanCertsFromDb() function seems unnecessary, Certdbv is a volatile variable so it doesn't need clean up logic on system crash. Other parts are good for me. Reviewed-by: Siyuan Fu -Original Message- From: Zhang, Chao B Sent: Friday,

Re: [edk2] [PATCH 2/2] SecurityPkg: AuthVariableLib: Add new cert database for volatile time based Auth variable

Siyuan: You are correct. CleanCertsFromDb is dedicated for NV time based variable. The change is just to cooperate DeleteCertsFromDb interface change. Thanks & Best regards Chao Zhang -Original Message- From: Fu, Siyuan Sent: Friday, January 29, 2016 3:06 PM To: Zhang, Chao B;