Re: [edk2] [PATCH 2/6] IntelFrameworkModulePkg: fix build for AARCH64/ARM

2018-11-02 Thread Gao, Liming
That's good. Thanks! > -Original Message- > From: Leif Lindholm [mailto:leif.lindh...@linaro.org] > Sent: Friday, November 2, 2018 6:15 PM > To: Gao, Liming > Cc: edk2-devel@lists.01.org > Subject: Re: [PATCH 2/6] IntelFrameworkModulePkg: fix build for AARCH64/ARM > > On Fri, Nov 02, 201

Re: [edk2] [PATCH 2/6] IntelFrameworkModulePkg: fix build for AARCH64/ARM

2018-11-02 Thread Leif Lindholm
On Fri, Nov 02, 2018 at 01:39:24AM +, Gao, Liming wrote: > Leif: > There is one mistake in comments >+ #^M. Could you clean it? > With this change, Reviewed-by: Liming Gao . Whoops, thanks for spotting. Will do. > Besides, have you verified AARCH64 GCC build? AARCH64 and ARM, GCC5

Re: [edk2] [PATCH 2/6] IntelFrameworkModulePkg: fix build for AARCH64/ARM

2018-11-01 Thread Gao, Liming
Leif: There is one mistake in comments >+ #^M. Could you clean it? With this change, Reviewed-by: Liming Gao . Besides, have you verified AARCH64 GCC build? Thanks Liming >-Original Message- >From: Leif Lindholm [mailto:leif.lindh...@linaro.org] >Sent: Thursday, November 01, 201

[edk2] [PATCH 2/6] IntelFrameworkModulePkg: fix build for AARCH64/ARM

2018-11-01 Thread Leif Lindholm
Contrary to what the name suggests, some modules in this package are used on other architecture. ARM is already listed in SUPPORTED_ARCHITECTURES in the .dsc, but AARCH64 was never added. Add that, and force inclusion of CompilerIntrinsicsLib and BaseStackCheckLib for AARCH64/ARM to make the build