Re: [edk2] [PATCH 3/3] ArmVirtPkg/FdtClientDxe: make DT table installation !ACPI dependent

2017-03-13 Thread Laszlo Ersek
On 03/13/17 21:39, Laszlo Ersek wrote: > On 03/13/17 15:59, Ard Biesheuvel wrote: >> On 13 March 2017 at 14:53, Laszlo Ersek wrote: >>> On 03/13/17 11:23, Ard Biesheuvel wrote: On 11 March 2017 at 10:26, Leif Lindholm wrote: > On Sat, Mar 11, 2017 at 08:38:19AM +0100, Laszlo Ersek wrote:

Re: [edk2] [PATCH 3/3] ArmVirtPkg/FdtClientDxe: make DT table installation !ACPI dependent

2017-03-13 Thread Ard Biesheuvel
On 13 March 2017 at 20:39, Laszlo Ersek wrote: > On 03/13/17 15:59, Ard Biesheuvel wrote: >> On 13 March 2017 at 14:53, Laszlo Ersek wrote: >>> On 03/13/17 11:23, Ard Biesheuvel wrote: On 11 March 2017 at 10:26, Leif Lindholm wrote: > On Sat, Mar 11, 2017 at 08:38:19AM +0100, Laszlo Ers

Re: [edk2] [PATCH 3/3] ArmVirtPkg/FdtClientDxe: make DT table installation !ACPI dependent

2017-03-13 Thread Laszlo Ersek
On 03/13/17 15:59, Ard Biesheuvel wrote: > On 13 March 2017 at 14:53, Laszlo Ersek wrote: >> On 03/13/17 11:23, Ard Biesheuvel wrote: >>> On 11 March 2017 at 10:26, Leif Lindholm wrote: On Sat, Mar 11, 2017 at 08:38:19AM +0100, Laszlo Ersek wrote: >>> "MdeModulePkg/Universal/Acpi/S3SaveS

Re: [edk2] [PATCH 3/3] ArmVirtPkg/FdtClientDxe: make DT table installation !ACPI dependent

2017-03-13 Thread Ard Biesheuvel
On 13 March 2017 at 14:53, Laszlo Ersek wrote: > On 03/13/17 11:23, Ard Biesheuvel wrote: >> On 11 March 2017 at 10:26, Leif Lindholm wrote: >>> On Sat, Mar 11, 2017 at 08:38:19AM +0100, Laszlo Ersek wrote: >> "MdeModulePkg/Universal/Acpi/S3SaveStateDxe/AcpiS3ContextSave.c". I >> think th

Re: [edk2] [PATCH 3/3] ArmVirtPkg/FdtClientDxe: make DT table installation !ACPI dependent

2017-03-13 Thread Laszlo Ersek
On 03/13/17 11:23, Ard Biesheuvel wrote: > On 11 March 2017 at 10:26, Leif Lindholm wrote: >> On Sat, Mar 11, 2017 at 08:38:19AM +0100, Laszlo Ersek wrote: > "MdeModulePkg/Universal/Acpi/S3SaveStateDxe/AcpiS3ContextSave.c". I > think the above check should be reworked to look for the FADT

Re: [edk2] [PATCH 3/3] ArmVirtPkg/FdtClientDxe: make DT table installation !ACPI dependent

2017-03-13 Thread Ard Biesheuvel
On 11 March 2017 at 10:26, Leif Lindholm wrote: > On Sat, Mar 11, 2017 at 08:38:19AM +0100, Laszlo Ersek wrote: >> >> "MdeModulePkg/Universal/Acpi/S3SaveStateDxe/AcpiS3ContextSave.c". I >> >> think the above check should be reworked to look for the FADT >> >> (EFI_ACPI_2_0_FIXED_ACPI_DESCRIPTION_T

Re: [edk2] [PATCH 3/3] ArmVirtPkg/FdtClientDxe: make DT table installation !ACPI dependent

2017-03-11 Thread Leif Lindholm
On Sat, Mar 11, 2017 at 08:38:19AM +0100, Laszlo Ersek wrote: > >> "MdeModulePkg/Universal/Acpi/S3SaveStateDxe/AcpiS3ContextSave.c". I > >> think the above check should be reworked to look for the FADT > >> (EFI_ACPI_2_0_FIXED_ACPI_DESCRIPTION_TABLE_SIGNATURE) with code lifted > >> from these helpe

Re: [edk2] [PATCH 3/3] ArmVirtPkg/FdtClientDxe: make DT table installation !ACPI dependent

2017-03-11 Thread Laszlo Ersek
On 03/11/17 10:19, Ard Biesheuvel wrote: > On 11 March 2017 at 08:41, Laszlo Ersek wrote: >> On 03/11/17 08:30, Ard Biesheuvel wrote: >>> On 11 Mar 2017, at 08:21, Laszlo Ersek wrote: > On 03/11/17 06:55, Laszlo Ersek wrote: >> On 03/09/17 17:04, Ard Biesheuvel wrote: >> Ins

Re: [edk2] [PATCH 3/3] ArmVirtPkg/FdtClientDxe: make DT table installation !ACPI dependent

2017-03-11 Thread Ard Biesheuvel
On 11 March 2017 at 08:41, Laszlo Ersek wrote: > On 03/11/17 08:30, Ard Biesheuvel wrote: >> >>> On 11 Mar 2017, at 08:21, Laszlo Ersek wrote: >>> On 03/11/17 06:55, Laszlo Ersek wrote: > On 03/09/17 17:04, Ard Biesheuvel wrote: > Instead of having a build time switch to prevent the

Re: [edk2] [PATCH 3/3] ArmVirtPkg/FdtClientDxe: make DT table installation !ACPI dependent

2017-03-10 Thread Laszlo Ersek
On 03/11/17 08:30, Ard Biesheuvel wrote: > >> On 11 Mar 2017, at 08:21, Laszlo Ersek wrote: >> >>> On 03/11/17 06:55, Laszlo Ersek wrote: On 03/09/17 17:04, Ard Biesheuvel wrote: Instead of having a build time switch to prevent the FDT configuration table from being installed, make

Re: [edk2] [PATCH 3/3] ArmVirtPkg/FdtClientDxe: make DT table installation !ACPI dependent

2017-03-10 Thread Laszlo Ersek
On 03/11/17 07:57, Ard Biesheuvel wrote: > On 11 March 2017 at 06:55, Laszlo Ersek wrote: >> On 03/09/17 17:04, Ard Biesheuvel wrote: >>> Instead of having a build time switch to prevent the FDT configuration >>> table from being installed, make this behavior dependent on whether we >>> are passin

Re: [edk2] [PATCH 3/3] ArmVirtPkg/FdtClientDxe: make DT table installation !ACPI dependent

2017-03-10 Thread Ard Biesheuvel
> On 11 Mar 2017, at 08:21, Laszlo Ersek wrote: > >> On 03/11/17 06:55, Laszlo Ersek wrote: >>> On 03/09/17 17:04, Ard Biesheuvel wrote: >>> Instead of having a build time switch to prevent the FDT configuration >>> table from being installed, make this behavior dependent on whether we >>> are p

Re: [edk2] [PATCH 3/3] ArmVirtPkg/FdtClientDxe: make DT table installation !ACPI dependent

2017-03-10 Thread Laszlo Ersek
On 03/11/17 06:55, Laszlo Ersek wrote: > On 03/09/17 17:04, Ard Biesheuvel wrote: >> Instead of having a build time switch to prevent the FDT configuration >> table from being installed, make this behavior dependent on whether we >> are passing ACPI tables to the OS. This is done by looking for the

Re: [edk2] [PATCH 3/3] ArmVirtPkg/FdtClientDxe: make DT table installation !ACPI dependent

2017-03-10 Thread Ard Biesheuvel
On 11 March 2017 at 06:55, Laszlo Ersek wrote: > On 03/09/17 17:04, Ard Biesheuvel wrote: >> Instead of having a build time switch to prevent the FDT configuration >> table from being installed, make this behavior dependent on whether we >> are passing ACPI tables to the OS. This is done by lookin

Re: [edk2] [PATCH 3/3] ArmVirtPkg/FdtClientDxe: make DT table installation !ACPI dependent

2017-03-10 Thread Laszlo Ersek
On 03/09/17 17:04, Ard Biesheuvel wrote: > Instead of having a build time switch to prevent the FDT configuration > table from being installed, make this behavior dependent on whether we > are passing ACPI tables to the OS. This is done by looking for the > ACPI 2.0 configuration table, and only in

Re: [edk2] [PATCH 3/3] ArmVirtPkg/FdtClientDxe: make DT table installation !ACPI dependent

2017-03-09 Thread Laszlo Ersek
On 03/09/17 17:04, Ard Biesheuvel wrote: > Instead of having a build time switch to prevent the FDT configuration > table from being installed, make this behavior dependent on whether we > are passing ACPI tables to the OS. This is done by looking for the > ACPI 2.0 configuration table, and only in

Re: [edk2] [PATCH 3/3] ArmVirtPkg/FdtClientDxe: make DT table installation !ACPI dependent

2017-03-09 Thread Leif Lindholm
On Thu, Mar 09, 2017 at 05:04:01PM +0100, Ard Biesheuvel wrote: > Instead of having a build time switch to prevent the FDT configuration > table from being installed, make this behavior dependent on whether we > are passing ACPI tables to the OS. This is done by looking for the > ACPI 2.0 configura

[edk2] [PATCH 3/3] ArmVirtPkg/FdtClientDxe: make DT table installation !ACPI dependent

2017-03-09 Thread Ard Biesheuvel
Instead of having a build time switch to prevent the FDT configuration table from being installed, make this behavior dependent on whether we are passing ACPI tables to the OS. This is done by looking for the ACPI 2.0 configuration table, and only installing the FDT one if the ACPI one cannot be fo