Re: [edk2] [PATCH 3/3] MdeModulePkg: TerminalDxe: select the UART's default receive FIFO depth

2016-01-26 Thread Leif Lindholm
On Tue, Jan 26, 2016 at 03:19:45PM +0100, Laszlo Ersek wrote: > >> Is this wise? It looks like BDS history repeating itself :-/ > > > > Well, medium-term, I'd (optimally) like to see ArmVirtPkg split and go > > into OvmfPkg one end and ArmPkg the other. > > > > But when Laszlo started out with A

Re: [edk2] [PATCH 3/3] MdeModulePkg: TerminalDxe: select the UART's default receive FIFO depth

2016-01-26 Thread Laszlo Ersek
On 01/26/16 15:48, Ryan Harkin wrote: > On 26 January 2016 at 14:19, Laszlo Ersek wrote: >> On 01/26/16 10:40, Leif Lindholm wrote: >>> On Tue, Jan 26, 2016 at 09:12:39AM +, Ryan Harkin wrote: > However there seems to be > some interference from "ArmPlatformPkg/Library/PlatformIntelBds

Re: [edk2] [PATCH 3/3] MdeModulePkg: TerminalDxe: select the UART's default receive FIFO depth

2016-01-26 Thread Ryan Harkin
On 26 January 2016 at 14:19, Laszlo Ersek wrote: > On 01/26/16 10:40, Leif Lindholm wrote: >> On Tue, Jan 26, 2016 at 09:12:39AM +, Ryan Harkin wrote: However there seems to be some interference from "ArmPlatformPkg/Library/PlatformIntelBdsLib" that is supposed to connect PcdDef

Re: [edk2] [PATCH 3/3] MdeModulePkg: TerminalDxe: select the UART's default receive FIFO depth

2016-01-26 Thread Laszlo Ersek
On 01/26/16 10:40, Leif Lindholm wrote: > On Tue, Jan 26, 2016 at 09:12:39AM +, Ryan Harkin wrote: >>> However there seems to be >>> some interference from "ArmPlatformPkg/Library/PlatformIntelBdsLib" that >>> is supposed to connect PcdDefaultConInPaths and PcdDefaultConOutPaths. >>> In order t

Re: [edk2] [PATCH 3/3] MdeModulePkg: TerminalDxe: select the UART's default receive FIFO depth

2016-01-26 Thread Leif Lindholm
On Tue, Jan 26, 2016 at 09:12:39AM +, Ryan Harkin wrote: > > However there seems to be > > some interference from "ArmPlatformPkg/Library/PlatformIntelBdsLib" that > > is supposed to connect PcdDefaultConInPaths and PcdDefaultConOutPaths. > > In order to experiment with F9, Roy massaged the las

Re: [edk2] [PATCH 3/3] MdeModulePkg: TerminalDxe: select the UART's default receive FIFO depth

2016-01-26 Thread Ryan Harkin
aszlo Ersek [mailto:ler...@redhat.com] >> Sent: Friday, January 22, 2016 3:56 AM >> To: Ryan Harkin >> Cc: Ni, Ruiyu ; Leif Lindholm >> ; edk2-de...@ml01.01.org; Zeng, Star >> ; Ard Biesheuvel ; Roy Franz >> >> Subject: Re: [edk2] [PATCH 3/3] MdeModulePkg: T

Re: [edk2] [PATCH 3/3] MdeModulePkg: TerminalDxe: select the UART's default receive FIFO depth

2016-01-25 Thread Laszlo Ersek
tar ; Ard Biesheuvel > ; Roy Franz > Subject: Re: [edk2] [PATCH 3/3] MdeModulePkg: TerminalDxe: select the UART's > default receive FIFO depth > > On 01/21/16 20:47, Ryan Harkin wrote: >> On 21 January 2016 at 18:14, Laszlo Ersek wrote: >>> On 01/21/16 18:57, Ryan

Re: [edk2] [PATCH 3/3] MdeModulePkg: TerminalDxe: select the UART's default receive FIFO depth

2016-01-25 Thread Ni, Ruiyu
...@ml01.01.org; Zeng, Star ; Ard Biesheuvel ; Roy Franz Subject: Re: [edk2] [PATCH 3/3] MdeModulePkg: TerminalDxe: select the UART's default receive FIFO depth On 01/21/16 20:47, Ryan Harkin wrote: > On 21 January 2016 at 18:14, Laszlo Ersek wrote: >> On 01/21/16 18:57, Ryan Harkin wr

Re: [edk2] [PATCH 3/3] MdeModulePkg: TerminalDxe: select the UART's default receive FIFO depth

2016-01-21 Thread Laszlo Ersek
On 01/21/16 20:47, Ryan Harkin wrote: > On 21 January 2016 at 18:14, Laszlo Ersek wrote: >> On 01/21/16 18:57, Ryan Harkin wrote: >>> On 21 January 2016 at 17:19, Laszlo Ersek wrote: >> Ryan, can you please test the following configuration: - your PCD update in place, but this three-par

Re: [edk2] [PATCH 3/3] MdeModulePkg: TerminalDxe: select the UART's default receive FIFO depth

2016-01-21 Thread Ryan Harkin
On 21 January 2016 at 18:14, Laszlo Ersek wrote: > On 01/21/16 18:57, Ryan Harkin wrote: >> On 21 January 2016 at 17:19, Laszlo Ersek wrote: > >>> Ryan, can you please test the following configuration: >>> - your PCD update in place, but this three-part series of mine >>> *reverted* >>> >>> Thi

Re: [edk2] [PATCH 3/3] MdeModulePkg: TerminalDxe: select the UART's default receive FIFO depth

2016-01-21 Thread Laszlo Ersek
On 01/21/16 18:57, Ryan Harkin wrote: > On 21 January 2016 at 17:19, Laszlo Ersek wrote: >> Ryan, can you please test the following configuration: >> - your PCD update in place, but this three-part series of mine >> *reverted* >> >> This should break the cursor movement keys again, and also bre

Re: [edk2] [PATCH 3/3] MdeModulePkg: TerminalDxe: select the UART's default receive FIFO depth

2016-01-21 Thread Ryan Harkin
dePkg follow >>> standards strictly. >>> >>> (3) We more or less patched the same for ArmVirtQemu (please refer to >>> git commit a51c1699), but differently. That difference is due to the >>> fact that ArmVirtQemu uses its own, independent PlatformBdsLib

Re: [edk2] [PATCH 3/3] MdeModulePkg: TerminalDxe: select the UART's default receive FIFO depth

2016-01-21 Thread Ryan Harkin
On 21 January 2016 at 17:44, Leif Lindholm wrote: > On Thu, Jan 21, 2016 at 05:36:41PM +, Ryan Harkin wrote: >> On 21 January 2016 at 17:32, Leif Lindholm wrote: >> > On Thu, Jan 21, 2016 at 06:19:22PM +0100, Laszlo Ersek wrote: >> >> Anyway, another question (for the ArmPlatformPkg maintaine

Re: [edk2] [PATCH 3/3] MdeModulePkg: TerminalDxe: select the UART's default receive FIFO depth

2016-01-21 Thread Leif Lindholm
On Thu, Jan 21, 2016 at 05:36:41PM +, Ryan Harkin wrote: > On 21 January 2016 at 17:32, Leif Lindholm wrote: > > On Thu, Jan 21, 2016 at 06:19:22PM +0100, Laszlo Ersek wrote: > >> Anyway, another question (for the ArmPlatformPkg maintainers as well): > >> do you guys think that the PCD update

Re: [edk2] [PATCH 3/3] MdeModulePkg: TerminalDxe: select the UART's default receive FIFO depth

2016-01-21 Thread Ryan Harkin
On 21 January 2016 at 17:32, Leif Lindholm wrote: > On Thu, Jan 21, 2016 at 06:19:22PM +0100, Laszlo Ersek wrote: >> Anyway, another question (for the ArmPlatformPkg maintainers as well): >> do you guys think that the PCD update in question should be commited to >> the repo, for the FVP (and maybe

Re: [edk2] [PATCH 3/3] MdeModulePkg: TerminalDxe: select the UART's default receive FIFO depth

2016-01-21 Thread Leif Lindholm
On Thu, Jan 21, 2016 at 06:19:22PM +0100, Laszlo Ersek wrote: > Anyway, another question (for the ArmPlatformPkg maintainers as well): > do you guys think that the PCD update in question should be commited to > the repo, for the FVP (and maybe Foundation) DSC files? After all those > are mostly use

Re: [edk2] [PATCH 3/3] MdeModulePkg: TerminalDxe: select the UART's default receive FIFO depth

2016-01-21 Thread Laszlo Ersek
t;> ("ArmVirtPkg/Library/PlatformIntelBdsLib"). Hence a51c1699 isn't >> portable to "ArmPlatformPkg/Library/PlatformIntelBdsLib", which is used >> by FVP. But the method described in (1) should work for you. >> >> Thanks >> Laszlo >> >

Re: [edk2] [PATCH 3/3] MdeModulePkg: TerminalDxe: select the UART's default receive FIFO depth

2016-01-21 Thread Ryan Harkin
;t seem to know about TTYTERMTYPE >>> - if you change the setting, you can only commit it with F10, >>> apparently, which doesn't work to begin with. >>> ... Wait, if you keep exiting the dialogs (not discarding the >>> changes!), ultimately it will as

Re: [edk2] [PATCH 3/3] MdeModulePkg: TerminalDxe: select the UART's default receive FIFO depth

2016-01-21 Thread Laszlo Ersek
gt;> changes!), ultimately it will ask you about saving changes. >> >> If you apply the attached patch, you should be able to select VT_TTY in >> the above menu option, in the Intel BDS. After that (possibly after a >> reboot), F9 should also start to work. Can you test thi

Re: [edk2] [PATCH 3/3] MdeModulePkg: TerminalDxe: select the UART's default receive FIFO depth

2016-01-21 Thread Ryan Harkin
he data. I remember discussing this with Roy when he was making his TTY changes elsewhere too. I makes me weak... > Thanks > Laszlo > >> >> >>> Regards, >>> Ray >>> >>> >>> -Original Message- >>> From: Ryan Harkin [

Re: [edk2] [PATCH 3/3] MdeModulePkg: TerminalDxe: select the UART's default receive FIFO depth

2016-01-21 Thread Laszlo Ersek
;>>>> >>>>> No clue, sorry. All we determined was that the FIFO depth of 1 caused >>>>> the PL011Uart library to disable queueing on the device completely. >>>>> Apparently, for handling isolated scan codes, no FIFO logic is necessary >

Re: [edk2] [PATCH 3/3] MdeModulePkg: TerminalDxe: select the UART's default receive FIFO depth

2016-01-21 Thread Ryan Harkin
gt;>>> scan codes didn't.) >>>> >>> >>> I don't know if it's related, but when looking into why copy/paste >>> doesn't work past one FIFO length, another Linaro team proposed that >>> the timeout was too short for our baud rate.

Re: [edk2] [PATCH 3/3] MdeModulePkg: TerminalDxe: select the UART's default receive FIFO depth

2016-01-21 Thread Ni, Ruiyu
, I fully agree that TerminalDxe should be able to work with any >>>> SerialIO protocol instance, regardless of what UART driver produced it. >>>> >>>> However, the consequence that I draw from this requirement is different >>>> from yours. My argum

Re: [edk2] [PATCH 3/3] MdeModulePkg: TerminalDxe: select the UART's default receive FIFO depth

2016-01-21 Thread Ryan Harkin
t; SerialIO protocol instance, regardless of what UART driver produced it. >>>> >>>> However, the consequence that I draw from this requirement is different >>>> from yours. My argument goes, if TerminalDxe cannot (and it should not) >>>> as

Re: [edk2] [PATCH 3/3] MdeModulePkg: TerminalDxe: select the UART's default receive FIFO depth

2016-01-21 Thread Laszlo Ersek
>> Ray >>> >>> -Original Message- >>> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >>> Laszlo Ersek >>> Sent: Thursday, January 21, 2016 11:23 AM >>> To: Ni, Ruiyu >>> Cc: Leif Lindholm ;

Re: [edk2] [PATCH 3/3] MdeModulePkg: TerminalDxe: select the UART's default receive FIFO depth

2016-01-21 Thread Ryan Harkin
anks > Laszlo > >> >> Regards, >> Ray >> >> -Original Message- >> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >> Laszlo Ersek >> Sent: Thursday, January 21, 2016 11:23 AM >> To: Ni, Ruiyu >> Cc: Le

Re: [edk2] [PATCH 3/3] MdeModulePkg: TerminalDxe: select the UART's default receive FIFO depth

2016-01-21 Thread Laszlo Ersek
ould see, so we > should try to conform in the reference implementation. > > But, whatever works. Feel free to revert my patches, or restore those > bits as part of another solution. > > Thanks > Laszlo > >> >> Regards, >> Ray >> >> -Original

Re: [edk2] [PATCH 3/3] MdeModulePkg: TerminalDxe: select the UART's default receive FIFO depth

2016-01-20 Thread Ni, Ruiyu
.@lists.01.org] On Behalf Of Laszlo Ersek Sent: Thursday, January 21, 2016 11:23 AM To: Ni, Ruiyu Cc: Leif Lindholm ; edk2-de...@ml01.01.org; Ryan Harkin ; Zeng, Star ; Ard Biesheuvel Subject: Re: [edk2] [PATCH 3/3] MdeModulePkg: TerminalDxe: select the UART's default receive FIFO depth On

Re: [edk2] [PATCH 3/3] MdeModulePkg: TerminalDxe: select the UART's default receive FIFO depth

2016-01-20 Thread Laszlo Ersek
hanks Laszlo > > Regards, > Ray > > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo > Ersek > Sent: Tuesday, January 19, 2016 9:54 PM > To: edk2-de...@ml01.01.org > Cc: Ryan Harkin ; Zeng, Star ; > L

Re: [edk2] [PATCH 3/3] MdeModulePkg: TerminalDxe: select the UART's default receive FIFO depth

2016-01-20 Thread Ni, Ruiyu
k2] [PATCH 3/3] MdeModulePkg: TerminalDxe: select the UART's default receive FIFO depth The Serial IO protocol instances provided by SerialDxe and consumed by TerminalDxe come with a Mode.ReceiveFifoDepth=1 default setting, as required by UEFI 2.5. Although Te

[edk2] [PATCH 3/3] MdeModulePkg: TerminalDxe: select the UART's default receive FIFO depth

2016-01-19 Thread Laszlo Ersek
The Serial IO protocol instances provided by SerialDxe and consumed by TerminalDxe come with a Mode.ReceiveFifoDepth=1 default setting, as required by UEFI 2.5. Although TerminalDxe calls EFI_SERIAL_IO_PROTOCOL.SetAttributes() in the TerminalDriverBindingStart() and TerminalConInTimerHandler() fun