Re: [edk2] [PATCH 3/3] UefiCpuPkg/CpuExceptionHandlerLib: Add stack switch support

2017-11-05 Thread Yao, Jiewen
AsmWriteTr, > IA32_TASK_STATE_SEGMENT, IA32_TSS_DESCRIPTOR to MdePkg(Such as BaseLib) > For this patch, I have no strong opinion. > > > 发件人: Yao, Jiewen<mailto:jiewen@intel.com> > 发送时间: 2017年11月1日 9:56 > 收件人: Wang, Jian J<mailto:jian.j.w...@intel.com>; > edk2-devel@li

Re: [edk2] [PATCH 3/3] UefiCpuPkg/CpuExceptionHandlerLib: Add stack switch support

2017-11-05 Thread Wang, Jian J
> IA32_TASK_STATE_SEGMENT, IA32_TSS_DESCRIPTOR to MdePkg(Such as BaseLib) > For this patch, I have no strong opinion. > > > 发件人: Yao, Jiewen<mailto:jiewen@intel.com> > 发送时间: 2017年11月1日 9:56 > 收件人: Wang, Jian J<mailto:jian.j.w...@intel.com>; > edk2

Re: [edk2] [PATCH 3/3] UefiCpuPkg/CpuExceptionHandlerLib: Add stack switch support

2017-11-05 Thread Yao, Jiewen
L Cpu Exception Handler instance is > chosen. > > For long term, I agree we need to move AsmWriteTr, > IA32_TASK_STATE_SEGMENT, IA32_TSS_DESCRIPTOR to MdePkg(Such as BaseLib) > For this patch, I have no strong opinion. > > > 发件人: Yao, Jiewen<mailto:jiewen....@intel.com> > 发送时间

Re: [edk2] [PATCH 3/3] UefiCpuPkg/CpuExceptionHandlerLib: Add stack switch support

2017-11-05 Thread Wang, Jian J
no strong opinion. > > > 发件人: Yao, Jiewen<mailto:jiewen....@intel.com> > 发送时间: 2017年11月1日 9:56 > 收件人: Wang, Jian J<mailto:jian.j.w...@intel.com>; > edk2-devel@lists.01.org<mailto:edk2-devel@lists.01.org<mailto:edk2-devel@lists.01.org%3cmailto:edk2-d

Re: [edk2] [PATCH 3/3] UefiCpuPkg/CpuExceptionHandlerLib: Add stack switch support

2017-11-02 Thread Wang, Jian J
1, 2017 7:33 PM > > > > To: Yao, Jiewen <jiewen@intel.com>; Wang, Jian J > > > <jian.j.w...@intel.com>; > > > > edk2-devel@lists.01.org > > > > Cc: Kinney, Michael D <michael.d.kin...@intel.com>; Dong, Eric > > > > <e

Re: [edk2] [PATCH 3/3] UefiCpuPkg/CpuExceptionHandlerLib: Add stack switch support

2017-11-02 Thread Yao, Jiewen
CpuExceptionHandlerLib: Add > > > stack switch support > > > > > > Per https://bugzilla.tianocore.org/show_bug.cgi?id=109, TR should be setup > > > (Such as in DxeIplPeim) even though NULL Cpu Exception Handler instance is > > > chosen. > > >

Re: [edk2] [PATCH 3/3] UefiCpuPkg/CpuExceptionHandlerLib: Add stack switch support

2017-11-02 Thread Yao, Jiewen
ng, Jian J<mailto:jian.j.w...@intel.com>; > edk2-devel@lists.01.org<mailto:edk2-devel@lists.01.org> > 抄送: Kinney, Michael D<mailto:michael.d.kin...@intel.com>; Dong, > Eric<mailto:eric.d...@intel.com>; Zeng, Star<mailto:star.z...@intel.com> > 主题: Re: [edk2] [

Re: [edk2] [PATCH 3/3] UefiCpuPkg/CpuExceptionHandlerLib: Add stack switch support

2017-11-01 Thread Kinney, Michael D
;; Dong, Eric<mailto:eric.d...@intel.com>; Zeng, Star<mailto:star.z...@intel.com> 主题: Re: [edk2] [PATCH 3/3] UefiCpuPkg/CpuExceptionHandlerLib: Add stack switch support Hi Jian Thanks for the patch. Can we move all IA32 defined data structure or function to MdePkg? Such as: AsmWriteT

Re: [edk2] [PATCH 3/3] UefiCpuPkg/CpuExceptionHandlerLib: Add stack switch support

2017-10-31 Thread Wang, Jian J
Star <star.z...@intel.com> > Subject: Re: [edk2] [PATCH 3/3] UefiCpuPkg/CpuExceptionHandlerLib: Add stack > switch support > > Jeff, > > Stack guard will still work. But the developer cannot know what’s going on > without exception dumping message when stack overflow occu

Re: [edk2] [PATCH 3/3] UefiCpuPkg/CpuExceptionHandlerLib: Add stack switch support

2017-10-31 Thread Wang, Jian J
ilto:edk2-devel@lists.01.org> 抄送: Kinney, Michael D<mailto:michael.d.kin...@intel.com>; Dong, Eric<mailto:eric.d...@intel.com>; Zeng, Star<mailto:star.z...@intel.com> 主题: Re: [edk2] [PATCH 3/3] UefiCpuPkg/CpuExceptionHandlerLib: Add stack switch support Hi Jian Thanks for the patch.

Re: [edk2] [PATCH 3/3] UefiCpuPkg/CpuExceptionHandlerLib: Add stack switch support

2017-10-31 Thread Wang, Jian J
ilto:star.z...@intel.com> 主题: Re: [edk2] [PATCH 3/3] UefiCpuPkg/CpuExceptionHandlerLib: Add stack switch support Hi Jian Thanks for the patch. Can we move all IA32 defined data structure or function to MdePkg? Such as: AsmWriteTr, IA32_TASK_STATE_SEGMENT, IA32_TSS_DESCRIPTOR I am also curious why we use

Re: [edk2] [PATCH 3/3] UefiCpuPkg/CpuExceptionHandlerLib: Add stack switch support

2017-10-31 Thread Wang, Jian J
om>; Dong, Eric <eric.d...@intel.com>; Zeng, Star <star.z...@intel.com> Subject: 答复: [edk2] [PATCH 3/3] UefiCpuPkg/CpuExceptionHandlerLib: Add stack switch support 1. Should add EFIAPI for the following function. +VOID +AsmWriteTr ( + UINT16 Selector + ); 2. Should no

Re: [edk2] [PATCH 3/3] UefiCpuPkg/CpuExceptionHandlerLib: Add stack switch support

2017-10-31 Thread Wang, Jian J
Hi Jiewen, Thanks for the feedback. > -Original Message- > From: Yao, Jiewen > Sent: Wednesday, November 01, 2017 9:57 AM > To: Wang, Jian J ; edk2-devel@lists.01.org > Cc: Zeng, Star ; Dong, Eric ; > Kinney, Michael D

Re: [edk2] [PATCH 3/3] UefiCpuPkg/CpuExceptionHandlerLib: Add stack switch support

2017-10-31 Thread Yao, Jiewen
Hi Jian Thanks for the patch. Can we move all IA32 defined data structure or function to MdePkg? Such as: AsmWriteTr, IA32_TASK_STATE_SEGMENT, IA32_TSS_DESCRIPTOR I am also curious why we use different policy for other boot mode. Can we use consistent policy? > + if (PcdGetBool

[edk2] [PATCH 3/3] UefiCpuPkg/CpuExceptionHandlerLib: Add stack switch support

2017-10-31 Thread Jian J Wang
If Stack Guard is enabled and there's really a stack overflow happened during boot, a Page Fault exception will be triggered. Because the stack is out of usage, the exception handler, which shares the stack with normal UEFI driver, cannot be executed and cannot dump the processor information.