subject:"\[edk2\] \[PATCH 4\/5\] SecurityPkg\: Enable Customized Secure Boot feature"

Re: [edk2] [PATCH 4/5] SecurityPkg: Enable Customized Secure Boot feature

2015-12-02 Thread Zhang, Chao B

ge- From: Zeng, Star Sent: Wednesday, December 02, 2015 11:54 AM To: Zhang, Chao B; edk2-devel@lists.01.org Cc: Zeng, Star; Long, Qin Subject: Re: [edk2] [PATCH 4/5] SecurityPkg: Enable Customized Secure Boot feature Hi Chao, I have comments below to this patch about AuthVariableLib upd

Re: [edk2] [PATCH 4/5] SecurityPkg: Enable Customized Secure Boot feature

2015-12-01 Thread Zeng, Star

Hi Chao, I have comments below to this patch about AuthVariableLib update. 1. Move SecureBootState to AuthService.c since it is only used by AuthService.c, and update the name to mSecureBootState. 2. Remove IsPkExist and SetupModeValAttr fields from SECURE_BOOT_MODE structure since only any

[edk2] [PATCH 4/5] SecurityPkg: Enable Customized Secure Boot feature

2015-11-02 Thread Zhang, Chao B

Enable Secure Boot feature defined in UEFI2.5 ECR1263. Add AuthVariable implementation logic. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Chao Zhang --- SecurityPkg/Library/AuthVariableLib/AuthService.c | 1221 +---