3 AM
> To: Carsey, Jaben
> Cc: edk2-devel-01 ; Laszlo Ersek
> ; Qiu, Shumin
> Subject: RE: [edk2] [PATCH 4/6] ShellPkg: don't call functions with side
> effects in ASSERT_EFI_ERROR()
> Importance: High
>
> Jaben,
> If and Else are using the same API.
> I would
> Sent: Thursday, July 7, 2016 10:42 PM
> To: Ni, Ruiyu
> Cc: edk2-devel-01 ; Laszlo Ersek
> ; Qiu, Shumin ; Carsey, Jaben
>
> Subject: RE: [edk2] [PATCH 4/6] ShellPkg: don't call functions with side
> effects in ASSERT_EFI_ERROR()
>
> We should see why If and Else are
t; Cc: Carsey, Jaben ; edk2-devel-01 de...@ml01.01.org>; Laszlo Ersek ; Qiu, Shumin
>
> Subject: RE: [edk2] [PATCH 4/6] ShellPkg: don't call functions with side
> effects in ASSERT_EFI_ERROR()
> Importance: High
>
> Jaben,
> CommandInit() API initializes gUnicodeCo
o:edk2-devel-boun...@lists.01.org] On Behalf Of
> Carsey, Jaben
> Sent: Thursday, June 30, 2016 11:13 PM
> To: Laszlo Ersek ; Qiu, Shumin
> Cc: Carsey, Jaben ; edk2-devel-01 de...@ml01.01.org>
> Subject: Re: [edk2] [PATCH 4/6] ShellPkg: don't call functions with side
Reviewed-by: Jaben Carsey
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Thursday, June 30, 2016 4:07 AM
> To: Carsey, Jaben ; Qiu, Shumin
>
> Cc: edk2-devel-01
> Subject: Re: [edk2] [PATCH 4/6] ShellPkg: don't call functi
Jaben, Shumin,
On 06/28/16 15:25, Laszlo Ersek wrote:
> When ASSERT_EFI_ERROR() is compiled out, dependent on build flags, only
> the status checking should be removed; the function calls should stay.
>
> Cc: Jaben Carsey
> Cc: Shumin Qiu
> Contributed-under: TianoCore Contribution Agreement 1.
n ; Qiu, Shumin
>Subject: Re: [edk2] [PATCH 4/6] ShellPkg: don't call functions with side
>effects in ASSERT_EFI_ERROR()
>
>On 06/29/16 08:36, Ni, Ruiyu wrote:
>> Laszlo,
>> Thanks for fixing such a big bug.
>>
>> I am curious how you detect such buggy code? By cod
>> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
>> Laszlo Ersek
>> Sent: Tuesday, June 28, 2016 9:26 PM
>> To: edk2-devel-01
>> Cc: Carsey, Jaben ; Qiu, Shumin
>>
>> Subject: [edk2] [PATCH 4/6] ShellPkg: don't call fu
2-devel-01
>Cc: Carsey, Jaben ; Qiu, Shumin
>Subject: [edk2] [PATCH 4/6] ShellPkg: don't call functions with side effects
>in ASSERT_EFI_ERROR()
>
>When ASSERT_EFI_ERROR() is compiled out, dependent on build flags, only
>the status checking should be removed; the function
Reviewed-by: Giri P Mudusuru
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo
> Ersek
> Sent: Tuesday, June 28, 2016 6:26 AM
> To: edk2-devel-01
> Cc: Carsey, Jaben ; Qiu, Shumin
>
> Subject: [edk2] [PATCH 4
When ASSERT_EFI_ERROR() is compiled out, dependent on build flags, only
the status checking should be removed; the function calls should stay.
Cc: Jaben Carsey
Cc: Shumin Qiu
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek
---
Notes:
build tested
Shell
11 matches
Mail list logo
