12:13 AM
> To: Carsey, Jaben <jaben.car...@intel.com>
> Cc: edk2-devel-01 <edk2-de...@ml01.01.org>; Laszlo Ersek
> <ler...@redhat.com>; Qiu, Shumin <shumin@intel.com>
> Subject: RE: [edk2] [PATCH 4/6] ShellPkg: don't call functions with side
> effects in
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf
> > > Of Carsey, Jaben
> > > Sent: Thursday, June 30, 2016 11:13 PM
> > > To: Laszlo Ersek <ler...@redhat.com>; Qiu, Shumin
> > <shumin@intel.com>
> > > Cc: Carsey, Jabe
n <jaben.car...@intel.com>
> Cc: Carsey, Jaben <jaben.car...@intel.com>; edk2-devel-01 de...@ml01.01.org>; Laszlo Ersek <ler...@redhat.com>; Qiu, Shumin
> <shumin....@intel.com>
> Subject: RE: [edk2] [PATCH 4/6] ShellPkg: don't call functions with side
> effects
e 30, 2016 4:07 AM
> > To: Carsey, Jaben <jaben.car...@intel.com>; Qiu, Shumin
> > <shumin@intel.com>
> > Cc: edk2-devel-01 <edk2-de...@ml01.01.org>
> > Subject: Re: [edk2] [PATCH 4/6] ShellPkg: don't call functions with
> > side effec
dk2-devel-01 <edk2-de...@ml01.01.org>
> Subject: Re: [edk2] [PATCH 4/6] ShellPkg: don't call functions with side
> effects in ASSERT_EFI_ERROR()
> Importance: High
>
> Jaben, Shumin,
>
> On 06/28/16 15:25, Laszlo Ersek wrote:
> > When ASSERT_EFI_ERROR() is compil
Jaben, Shumin,
On 06/28/16 15:25, Laszlo Ersek wrote:
> When ASSERT_EFI_ERROR() is compiled out, dependent on build flags, only
> the status checking should be removed; the function calls should stay.
>
> Cc: Jaben Carsey
> Cc: Shumin Qiu
>
lt;edk2-de...@ml01.01.org>
>Cc: Carsey, Jaben <jaben.car...@intel.com>; Qiu, Shumin <shumin....@intel.com>
>Subject: Re: [edk2] [PATCH 4/6] ShellPkg: don't call functions with side
>effects in ASSERT_EFI_ERROR()
>
>On 06/29/16 08:36, Ni, Ruiyu wrote:
>> Laszlo,
&g
devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
>> Laszlo Ersek
>> Sent: Tuesday, June 28, 2016 9:26 PM
>> To: edk2-devel-01 <edk2-de...@ml01.01.org>
>> Cc: Carsey, Jaben <jaben.car...@intel.com>; Qiu, Shumin
>> <shumin@intel.com>
-devel-01 <edk2-de...@ml01.01.org>
>Cc: Carsey, Jaben <jaben.car...@intel.com>; Qiu, Shumin <shumin....@intel.com>
>Subject: [edk2] [PATCH 4/6] ShellPkg: don't call functions with side effects
>in ASSERT_EFI_ERROR()
>
>When ASSERT_EFI_ERROR() is compiled out, dep
; Cc: Carsey, Jaben <jaben.car...@intel.com>; Qiu, Shumin
> <shumin....@intel.com>
> Subject: [edk2] [PATCH 4/6] ShellPkg: don't call functions with side effects
> in
> ASSERT_EFI_ERROR()
>
> When ASSERT_EFI_ERROR() is compiled out, dependent on build flags, only
> the st
When ASSERT_EFI_ERROR() is compiled out, dependent on build flags, only
the status checking should be removed; the function calls should stay.
Cc: Jaben Carsey
Cc: Shumin Qiu
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by:
11 matches
Mail list logo