Re: [edk2] [PATCH 4/6] ShellPkg: don't call functions with side effects in ASSERT_EFI_ERROR()

2016-07-12 Thread Carsey, Jaben
12:13 AM > To: Carsey, Jaben <jaben.car...@intel.com> > Cc: edk2-devel-01 <edk2-de...@ml01.01.org>; Laszlo Ersek > <ler...@redhat.com>; Qiu, Shumin <shumin@intel.com> > Subject: RE: [edk2] [PATCH 4/6] ShellPkg: don't call functions with side > effects in

Re: [edk2] [PATCH 4/6] ShellPkg: don't call functions with side effects in ASSERT_EFI_ERROR()

2016-07-12 Thread Ni, Ruiyu
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf > > > Of Carsey, Jaben > > > Sent: Thursday, June 30, 2016 11:13 PM > > > To: Laszlo Ersek <ler...@redhat.com>; Qiu, Shumin > > <shumin@intel.com> > > > Cc: Carsey, Jabe

Re: [edk2] [PATCH 4/6] ShellPkg: don't call functions with side effects in ASSERT_EFI_ERROR()

2016-07-07 Thread Carsey, Jaben
n <jaben.car...@intel.com> > Cc: Carsey, Jaben <jaben.car...@intel.com>; edk2-devel-01 de...@ml01.01.org>; Laszlo Ersek <ler...@redhat.com>; Qiu, Shumin > <shumin....@intel.com> > Subject: RE: [edk2] [PATCH 4/6] ShellPkg: don't call functions with side > effects

Re: [edk2] [PATCH 4/6] ShellPkg: don't call functions with side effects in ASSERT_EFI_ERROR()

2016-07-07 Thread Ni, Ruiyu
e 30, 2016 4:07 AM > > To: Carsey, Jaben <jaben.car...@intel.com>; Qiu, Shumin > > <shumin@intel.com> > > Cc: edk2-devel-01 <edk2-de...@ml01.01.org> > > Subject: Re: [edk2] [PATCH 4/6] ShellPkg: don't call functions with > > side effec

Re: [edk2] [PATCH 4/6] ShellPkg: don't call functions with side effects in ASSERT_EFI_ERROR()

2016-06-30 Thread Carsey, Jaben
dk2-devel-01 <edk2-de...@ml01.01.org> > Subject: Re: [edk2] [PATCH 4/6] ShellPkg: don't call functions with side > effects in ASSERT_EFI_ERROR() > Importance: High > > Jaben, Shumin, > > On 06/28/16 15:25, Laszlo Ersek wrote: > > When ASSERT_EFI_ERROR() is compil

Re: [edk2] [PATCH 4/6] ShellPkg: don't call functions with side effects in ASSERT_EFI_ERROR()

2016-06-30 Thread Laszlo Ersek
Jaben, Shumin, On 06/28/16 15:25, Laszlo Ersek wrote: > When ASSERT_EFI_ERROR() is compiled out, dependent on build flags, only > the status checking should be removed; the function calls should stay. > > Cc: Jaben Carsey > Cc: Shumin Qiu >

Re: [edk2] [PATCH 4/6] ShellPkg: don't call functions with side effects in ASSERT_EFI_ERROR()

2016-06-29 Thread Ni, Ruiyu
lt;edk2-de...@ml01.01.org> >Cc: Carsey, Jaben <jaben.car...@intel.com>; Qiu, Shumin <shumin....@intel.com> >Subject: Re: [edk2] [PATCH 4/6] ShellPkg: don't call functions with side >effects in ASSERT_EFI_ERROR() > >On 06/29/16 08:36, Ni, Ruiyu wrote: >> Laszlo, &g

Re: [edk2] [PATCH 4/6] ShellPkg: don't call functions with side effects in ASSERT_EFI_ERROR()

2016-06-29 Thread Laszlo Ersek
devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >> Laszlo Ersek >> Sent: Tuesday, June 28, 2016 9:26 PM >> To: edk2-devel-01 <edk2-de...@ml01.01.org> >> Cc: Carsey, Jaben <jaben.car...@intel.com>; Qiu, Shumin >> <shumin@intel.com>

Re: [edk2] [PATCH 4/6] ShellPkg: don't call functions with side effects in ASSERT_EFI_ERROR()

2016-06-29 Thread Ni, Ruiyu
-devel-01 <edk2-de...@ml01.01.org> >Cc: Carsey, Jaben <jaben.car...@intel.com>; Qiu, Shumin <shumin....@intel.com> >Subject: [edk2] [PATCH 4/6] ShellPkg: don't call functions with side effects >in ASSERT_EFI_ERROR() > >When ASSERT_EFI_ERROR() is compiled out, dep

Re: [edk2] [PATCH 4/6] ShellPkg: don't call functions with side effects in ASSERT_EFI_ERROR()

2016-06-28 Thread Mudusuru, Giri P
; Cc: Carsey, Jaben <jaben.car...@intel.com>; Qiu, Shumin > <shumin....@intel.com> > Subject: [edk2] [PATCH 4/6] ShellPkg: don't call functions with side effects > in > ASSERT_EFI_ERROR() > > When ASSERT_EFI_ERROR() is compiled out, dependent on build flags, only > the st

[edk2] [PATCH 4/6] ShellPkg: don't call functions with side effects in ASSERT_EFI_ERROR()

2016-06-28 Thread Laszlo Ersek
When ASSERT_EFI_ERROR() is compiled out, dependent on build flags, only the status checking should be removed; the function calls should stay. Cc: Jaben Carsey Cc: Shumin Qiu Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: