Re: [edk2] [PATCH V5 16/17] MdeModulePkg/PeiDebugLibDebugPpi: Add PEI debug lib

You are right. I didn't think about that. And I have change the variable to local and tested on open MinPlatform (Kabylake RVP3). It works fine. And also global variable make the system hang. Thanks, Zhichao > -Original Message- > From: Ni, Ray > Sent: Thursday, March 28, 2019 6:11 PM >

Re: [edk2] [PATCH V5 16/17] MdeModulePkg/PeiDebugLibDebugPpi: Add PEI debug lib

Zhichao, For a PEIM, it may not be proper to have a global variable and update that global variable during execution. Because sometimes the PEIM runs from read-only SPI flash, the global variable cannot be updated. I see you have a check against NULL when using that global variable. How about ju

[edk2] [PATCH V5 16/17] MdeModulePkg/PeiDebugLibDebugPpi: Add PEI debug lib

From: Liming Gao REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1549 Add a PEI debug library instance PeiDebugLibDebugPpi base on DebugPpi. Using the combination of the DebugServicePei and this lib instance can reduce the image size of PEI drivers. Contributed-under: TianoCore Contribution