[edk2] [PATCH edk2-platforms] Silicon/SynQuacerPciCpuIo2Dxe: fix PCIe I/O translation

2018-10-19 Thread Ard Biesheuvel
Commit 9dd8190e4995 ("Silicon/SynQuacer: tweak PCI I/O windows for ACPI/Linux support") updated the min/max/offset definitions for the PCIe I/O resource windows on SynQuacer, and updated the read path of the platform's EfiCpuIo2 protocol implementation, but failed to update the write path as well,

Re: [edk2] [PATCH edk2-platforms] Silicon/SynQuacerPciCpuIo2Dxe: fix PCIe I/O translation

2018-10-19 Thread Leif Lindholm
Looks good functionality-wise, but is a bit of a handful to look at (and not just because I'm code reviewing on a phone). Could you do it with a couple of temp vars? / Leif On Fri, 19 Oct 2018, 18:48 Ard Biesheuvel, wrote: > Commit 9dd8190e4995 ("Silicon/SynQuacer: tweak PCI I/O windows for

Re: [edk2] [PATCH edk2-platforms] Silicon/SynQuacerPciCpuIo2Dxe: fix PCIe I/O translation

2018-10-20 Thread Ard Biesheuvel
On 20 October 2018 at 14:52, Leif Lindholm wrote: > Looks good functionality-wise, but is a bit of a handful to look at (and not > just because I'm code reviewing on a phone). > Could you do it with a couple of temp vars? > Yes, but then CpuIoServiceWrite would deviate from CpuIoServiceRead, so I