Re: [edk2] [PATCH edk2-platforms v1 15/38] Silicon/Hisilicon/I2C: Optimize I2C library

2018-08-08 Thread Ming
在 8/3/2018 9:24 PM, Leif Lindholm 写道: > On Tue, Jul 24, 2018 at 03:08:59PM +0800, Ming Huang wrote: >> The hunt of waiting TX/TX finish is used by ten times, >> so move there hunts to a function CheckI2CTimeOut. > > I approve of this change, but the subject is inaccurate. > > Please change

Re: [edk2] [PATCH edk2-platforms v1 15/38] Silicon/Hisilicon/I2C: Optimize I2C library

2018-08-03 Thread Leif Lindholm
On Tue, Jul 24, 2018 at 03:08:59PM +0800, Ming Huang wrote: > The hunt of waiting TX/TX finish is used by ten times, > so move there hunts to a function CheckI2CTimeOut. I approve of this change, but the subject is inaccurate. Please change 'optimize' to 'refactor'. Some style comments below.

[edk2] [PATCH edk2-platforms v1 15/38] Silicon/Hisilicon/I2C: Optimize I2C library

2018-07-24 Thread Ming Huang
The hunt of waiting TX/TX finish is used by ten times, so move there hunts to a function CheckI2CTimeOut. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming Huang Signed-off-by: Heyi Guo --- Silicon/Hisilicon/Library/I2CLib/I2CHw.h | 4 +