Re: [edk2] [PATCH edk2-platforms v1 22/38] Platform/Hisilicon/D06: Add OemNicLib

2018-08-15 Thread Ming
在 8/15/2018 9:22 PM, Leif Lindholm 写道: > On Wed, Aug 15, 2018 at 07:08:33PM +0800, Ming wrote: > Yes please. > It would be good if we could have some (common) code to handle the > fluke situation where you end up without your own MAC address. > (So that the node can boot up and re

Re: [edk2] [PATCH edk2-platforms v1 22/38] Platform/Hisilicon/D06: Add OemNicLib

2018-08-15 Thread Leif Lindholm
On Wed, Aug 15, 2018 at 07:08:33PM +0800, Ming wrote: > >>> Yes please. > >>> It would be good if we could have some (common) code to handle the > >>> fluke situation where you end up without your own MAC address. > >>> (So that the node can boot up and report that it is broken.) > >>> But it needs

Re: [edk2] [PATCH edk2-platforms v1 22/38] Platform/Hisilicon/D06: Add OemNicLib

2018-08-15 Thread Ming
在 8/14/2018 11:48 PM, Leif Lindholm 写道: > On Tue, Aug 14, 2018 at 10:38:14AM +0800, Ming wrote: >> >> >> 在 8/9/2018 6:19 PM, Leif Lindholm 写道: >>> On Thu, Aug 09, 2018 at 02:16:49PM +0800, Ming wrote: >> +UINT16 crc_tab[256] = { > > CrcTable. Modify it in v2. > Hmm.

Re: [edk2] [PATCH edk2-platforms v1 22/38] Platform/Hisilicon/D06: Add OemNicLib

2018-08-14 Thread Leif Lindholm
On Tue, Aug 14, 2018 at 10:38:14AM +0800, Ming wrote: > > > 在 8/9/2018 6:19 PM, Leif Lindholm 写道: > > On Thu, Aug 09, 2018 at 02:16:49PM +0800, Ming wrote: > +UINT16 crc_tab[256] = { > >>> > >>> CrcTable. > >> > >> Modify it in v2. > >> > >>> Hmm. > >>> This might be useful to add to a core

Re: [edk2] [PATCH edk2-platforms v1 22/38] Platform/Hisilicon/D06: Add OemNicLib

2018-08-13 Thread Ming
在 8/9/2018 6:19 PM, Leif Lindholm 写道: > On Thu, Aug 09, 2018 at 02:16:49PM +0800, Ming wrote: +UINT16 crc_tab[256] = { >>> >>> CrcTable. >> >> Modify it in v2. >> >>> Hmm. >>> This might be useful to add to a core library/driver/protocol. We >>> don't appear to have it yet. This is another n

Re: [edk2] [PATCH edk2-platforms v1 22/38] Platform/Hisilicon/D06: Add OemNicLib

2018-08-09 Thread Ming
在 8/9/2018 6:19 PM, Leif Lindholm 写道: > On Thu, Aug 09, 2018 at 02:16:49PM +0800, Ming wrote: +UINT16 crc_tab[256] = { >>> >>> CrcTable. >> >> Modify it in v2. >> >>> Hmm. >>> This might be useful to add to a core library/driver/protocol. We >>> don't appear to have it yet. This is another n

Re: [edk2] [PATCH edk2-platforms v1 22/38] Platform/Hisilicon/D06: Add OemNicLib

2018-08-09 Thread Leif Lindholm
On Thu, Aug 09, 2018 at 02:16:49PM +0800, Ming wrote: > >> +UINT16 crc_tab[256] = { > > > > CrcTable. > > Modify it in v2. > > > Hmm. > > This might be useful to add to a core library/driver/protocol. We > > don't appear to have it yet. This is another note to the universe. > > Do you suggest t

Re: [edk2] [PATCH edk2-platforms v1 22/38] Platform/Hisilicon/D06: Add OemNicLib

2018-08-08 Thread Ming
在 8/3/2018 10:36 PM, Leif Lindholm 写道: > On Tue, Jul 24, 2018 at 03:09:06PM +0800, Ming Huang wrote: >> OemNicLib provide nic related api like GetMac,SetMac. >> >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by: Ming Huang >> Signed-off-by: Heyi Guo >> --- >> Platform

Re: [edk2] [PATCH edk2-platforms v1 22/38] Platform/Hisilicon/D06: Add OemNicLib

2018-08-03 Thread Leif Lindholm
On Tue, Jul 24, 2018 at 03:09:06PM +0800, Ming Huang wrote: > OemNicLib provide nic related api like GetMac,SetMac. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ming Huang > Signed-off-by: Heyi Guo > --- > Platform/Hisilicon/D06/D06.dsc |

[edk2] [PATCH edk2-platforms v1 22/38] Platform/Hisilicon/D06: Add OemNicLib

2018-07-24 Thread Ming Huang
OemNicLib provide nic related api like GetMac,SetMac. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming Huang Signed-off-by: Heyi Guo --- Platform/Hisilicon/D06/D06.dsc | 1 + Platform/Hisilicon/D06/Library/OemNicLib/OemNicLib.c | 571 +