Re: [edk2] [PATCH edk2-platforms v3 32/36] Silicon/Hisilicon/Setup: Support SPCR table switch

2018-08-23 Thread Ming
On 8/23/2018 7:12 PM, Leif Lindholm wrote: > I don't see how it would be less risky to include new code rather than using > the existing and well-tested solution for the same problem. OK, replace with ConsolePrefDxe in v4. > > On Thu, 23 Aug 2018, 11:51 Ming, >

Re: [edk2] [PATCH edk2-platforms v3 32/36] Silicon/Hisilicon/Setup: Support SPCR table switch

2018-08-23 Thread Leif Lindholm
I don't see how it would be less risky to include new code rather than using the existing and well-tested solution for the same problem. On Thu, 23 Aug 2018, 11:51 Ming, wrote: > Hi Leif, > > Is it ok replace with ConsolePrefDxe after ERP 18.08? > > > On 8/22/2018 10:49 AM, Ming wrote: > > > >

Re: [edk2] [PATCH edk2-platforms v3 32/36] Silicon/Hisilicon/Setup: Support SPCR table switch

2018-08-23 Thread Ming
Hi Leif, Is it ok replace with ConsolePrefDxe after ERP 18.08? On 8/22/2018 10:49 AM, Ming wrote: > > > On 8/22/2018 5:11 AM, Leif Lindholm wrote: >> On Thu, Aug 16, 2018 at 08:12:35PM +0800, Ming Huang wrote: >>> If install SPCR table, KVM will not output while install or boot >>> some OS,

Re: [edk2] [PATCH edk2-platforms v3 32/36] Silicon/Hisilicon/Setup: Support SPCR table switch

2018-08-21 Thread Leif Lindholm
On Thu, Aug 16, 2018 at 08:12:35PM +0800, Ming Huang wrote: > If install SPCR table, KVM will not output while install or boot > some OS, like ubuntu, so add SPCR switch setup item and set it > disable by default. This one was supposed to be replaced with EmbeddedPkg/Drivers/ConsolePrefDxe,

[edk2] [PATCH edk2-platforms v3 32/36] Silicon/Hisilicon/Setup: Support SPCR table switch

2018-08-16 Thread Ming Huang
If install SPCR table, KVM will not output while install or boot some OS, like ubuntu, so add SPCR switch setup item and set it disable by default. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming Huang Signed-off-by: Heyi Guo ---