Re: [edk2] [PATCH v1 1/2] MdeModulePkg: Minimize usage of FreePool() during ExitBS().

2016-06-22 Thread Marvin H?user
el.com] > Sent: Wednesday, June 22, 2016 9:55 PM > To: Marvin H?user <marvin.haeu...@outlook.com>; edk2- > de...@lists.01.org; Kinney, Michael D <michael.d.kin...@intel.com> > Subject: RE: [edk2] [PATCH v1 1/2] MdeModulePkg: Minimize usage of > FreePool() during ExitBS(). >

Re: [edk2] [PATCH v1 1/2] MdeModulePkg: Minimize usage of FreePool() during ExitBS().

2016-06-22 Thread Kinney, Michael D
t; H?user > Sent: Wednesday, June 22, 2016 12:32 PM > To: edk2-devel@lists.01.org > Cc: Kinney, Michael D <michael.d.kin...@intel.com> > Subject: Re: [edk2] [PATCH v1 1/2] MdeModulePkg: Minimize usage of FreePool() > during > ExitBS(). > > Hey Mike, > > Yes, I'm

Re: [edk2] [PATCH v1 1/2] MdeModulePkg: Minimize usage of FreePool() during ExitBS().

2016-06-22 Thread Marvin H?user
- > de...@lists.01.org; Kinney, Michael D <michael.d.kin...@intel.com> > Cc: Zeng, Star <star.z...@intel.com> > Subject: RE: [edk2] [PATCH v1 1/2] MdeModulePkg: Minimize usage of > FreePool() during ExitBS(). > > Marvin, > > If none of the exit boot services e

Re: [edk2] [PATCH v1 1/2] MdeModulePkg: Minimize usage of FreePool() during ExitBS().

2016-06-22 Thread Kinney, Michael D
er > Sent: Wednesday, June 22, 2016 4:27 AM > To: edk2-devel@lists.01.org > Cc: Zeng, Star <star.z...@intel.com> > Subject: Re: [edk2] [PATCH v1 1/2] MdeModulePkg: Minimize usage of FreePool() > during > ExitBS(). > > Hey Star, > > > I am still curious what is the

Re: [edk2] [PATCH v1 1/2] MdeModulePkg: Minimize usage of FreePool() during ExitBS().

2016-06-22 Thread Marvin H?user
feng.t...@intel.com> > Subject: Re: [edk2] [PATCH v1 1/2] MdeModulePkg: Minimize usage of > FreePool() during ExitBS(). > > On 2016/6/22 13:39, Bruce Cran wrote: > > On 6/19/16 9:21 PM, Zeng, Star wrote: > > > >> 1. The memory allocate and free in PiSmmCore are SM

Re: [edk2] [PATCH v1 1/2] MdeModulePkg: Minimize usage of FreePool() during ExitBS().

2016-06-22 Thread Zeng, Star
Cc Liming and Mike may have some comments. Thanks, Star On 2016/6/22 17:17, Zeng, Star wrote: On 2016/6/22 13:39, Bruce Cran wrote: On 6/19/16 9:21 PM, Zeng, Star wrote: 1. The memory allocate and free in PiSmmCore are SMRAM that is not related to UEFI memory map. 2. According to UEFI 2.6

Re: [edk2] [PATCH v1 1/2] MdeModulePkg: Minimize usage of FreePool() during ExitBS().

2016-06-22 Thread Zeng, Star
On 2016/6/22 13:39, Bruce Cran wrote: On 6/19/16 9:21 PM, Zeng, Star wrote: 1. The memory allocate and free in PiSmmCore are SMRAM that is not related to UEFI memory map. 2. According to UEFI 2.6 spec page 222 below, the UEFI OS loader should have got the memory map before ExitBootServices.

Re: [edk2] [PATCH v1 1/2] MdeModulePkg: Minimize usage of FreePool() during ExitBS().

2016-06-21 Thread Bruce Cran
On 6/19/16 9:21 PM, Zeng, Star wrote: 1. The memory allocate and free in PiSmmCore are SMRAM that is not related to UEFI memory map. 2. According to UEFI 2.6 spec page 222 below, the UEFI OS loader should have got the memory map before ExitBootServices. That means the memory free should not

Re: [edk2] [PATCH v1 1/2] MdeModulePkg: Minimize usage of FreePool() during ExitBS().

2016-06-20 Thread Andrew Fish
> On Jun 20, 2016, at 9:10 AM, Bruce Cran wrote: > > On 6/19/16 9:21 PM, Zeng, Star wrote: > >> 2. According to UEFI 2.6 spec page 222 below, the UEFI OS loader should have >> got the memory map before ExitBootServices. >> That means the memory free should not impact the

Re: [edk2] [PATCH v1 1/2] MdeModulePkg: Minimize usage of FreePool() during ExitBS().

2016-06-20 Thread Marvin H?user
: Zeng, Star <star.z...@intel.com>; marvin.haeu...@outlook.com; edk2- > de...@lists.01.org > Cc: Tian, Feng <feng.t...@intel.com> > Subject: Re: [edk2] [PATCH v1 1/2] MdeModulePkg: Minimize usage of > FreePool() during ExitBS(). > > On 6/19/16 9:21 PM, Zeng, Star wrote:

Re: [edk2] [PATCH v1 1/2] MdeModulePkg: Minimize usage of FreePool() during ExitBS().

2016-06-20 Thread Marvin Häuser
Hey Star, Thanks for your input! I agree, this has been a plain oversight by me. Would you be fine with a V2 of this patch lacking the modifications to the SMM code? There has been another place this change has been applied to - IScsiMisc.c. Thanks, Marvin. > -Original Message- >

Re: [edk2] [PATCH v1 1/2] MdeModulePkg: Minimize usage of FreePool() during ExitBS().

2016-06-20 Thread Bruce Cran
On 6/19/16 9:21 PM, Zeng, Star wrote: 2. According to UEFI 2.6 spec page 222 below, the UEFI OS loader should have got the memory map before ExitBootServices. That means the memory free should not impact the memory map *got by UEFI OS loader*, it will only impact the memory map if the UEFI OS

Re: [edk2] [PATCH v1 1/2] MdeModulePkg: Minimize usage of FreePool() during ExitBS().

2016-06-19 Thread Zeng, Star
Hi Marvin, 1. The memory allocate and free in PiSmmCore are SMRAM that is not related to UEFI memory map. 2. According to UEFI 2.6 spec page 222 below, the UEFI OS loader should have got the memory map before ExitBootServices. That means the memory free should not impact the memory map *got by

[edk2] [PATCH v1 1/2] MdeModulePkg: Minimize usage of FreePool() during ExitBS().

2016-06-19 Thread Marvin Häuser
During exiting Boot Services, there should be no changes made to the Memory Map. This patch eliminates calls to FreePool() and CloseEvent() (which calls FreePool()) and instead zero's the memory. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Marvin Haeuser