Re: [edk2] [PATCH v1 6/7] MdeModulePkg/UdfDxe: Remove dead codes in FileName.c

2018-10-16 Thread Wu, Hao A
te: > >> -Original Message- > >> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > >> Leif Lindholm > >> Sent: Tuesday, October 16, 2018 2:20 PM > >> To: Wu, Hao A > >> Cc: Ni, Ruiyu; edk2-devel@lists.01.org; Zeng, Star &

Re: [edk2] [PATCH v1 6/7] MdeModulePkg/UdfDxe: Remove dead codes in FileName.c

2018-10-16 Thread Zeng, Star
el@lists.01.org; Zeng, Star Subject: Re: [edk2] [PATCH v1 6/7] MdeModulePkg/UdfDxe: Remove dead codes in FileName.c On Mon, Oct 15, 2018 at 12:55:21PM +0800, Hao Wu wrote: REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1249 We found potential dead codes within File.c during the code coverage test

Re: [edk2] [PATCH v1 6/7] MdeModulePkg/UdfDxe: Remove dead codes in FileName.c

2018-10-15 Thread Wu, Hao A
> -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Leif Lindholm > Sent: Tuesday, October 16, 2018 2:20 PM > To: Wu, Hao A > Cc: Ni, Ruiyu; edk2-devel@lists.01.org; Zeng, Star > Subject: Re: [edk2] [PATCH v1 6/7] MdeModulePk

Re: [edk2] [PATCH v1 6/7] MdeModulePkg/UdfDxe: Remove dead codes in FileName.c

2018-10-15 Thread Leif Lindholm
On Mon, Oct 15, 2018 at 12:55:21PM +0800, Hao Wu wrote: > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1249 > > We found potential dead codes within File.c during the code coverage test. > > After manual review, we think the below ones are positive reports: > > A. In function MangleFileNam

[edk2] [PATCH v1 6/7] MdeModulePkg/UdfDxe: Remove dead codes in FileName.c

2018-10-14 Thread Hao Wu
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1249 We found potential dead codes within File.c during the code coverage test. After manual review, we think the below ones are positive reports: A. In function MangleFileName(): FileName = TrimString (FileName); // Begin of dead codes i