Re: [edk2] [PATCH v2] BaseTools: Fix build failure when specifying multiple BUILDTARGET

2019-02-06 Thread Philippe Mathieu-Daudé
On 2/6/19 10:11 PM, Carsey, Jaben wrote: > Reviewed-by: Jaben Carsey > > And pushed. Thanks! And I learned the hard way git config 'user.name' is obviously different than 'sendemail.from'... Liming asked me to not use non-ASCII character in commit message so I fixed my user.name, but forgot the

Re: [edk2] [PATCH v2] BaseTools: Fix build failure when specifying multiple BUILDTARGET

2019-02-06 Thread Carsey, Jaben
Reviewed-by: Jaben Carsey And pushed. > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Wednesday, February 06, 2019 8:26 AM > To: Philippe Mathieu-Daudé ; Kinney, Michael D > ; edk2-devel@lists.01.org; Carsey, Jaben > > Cc: Leif Lindholm > Subject: Re: [PATC

Re: [edk2] [PATCH v2] BaseTools: Fix build failure when specifying multiple BUILDTARGET

2019-02-06 Thread Laszlo Ersek
On 02/06/19 13:03, Philippe Mathieu-Daudé wrote: > With Python3, the dict.value() method returns an iterator. > If a dictionary is updated while an iterator on its keys is used, > a RuntimeError is generated. > Converting the iterator to a list() forces a copy of the mutable > keys in an immutable

Re: [edk2] [PATCH v2] BaseTools: Fix build failure when specifying multiple BUILDTARGET

2019-02-06 Thread Philippe Mathieu-Daudé
On 2/6/19 1:03 PM, Philippe Mathieu-Daudé wrote: [...] > > Reported-by: Leif Lindholm > Fixes: f8d11e5a4aaa90bf63b4789f3993dd6d16c60787 > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Philippe Mathieu-Daude > Tested-by: Leif Lindholm > Acked-by: Laszlo Ersek > --- >

[edk2] [PATCH v2] BaseTools: Fix build failure when specifying multiple BUILDTARGET

2019-02-06 Thread Philippe Mathieu-Daudé
With Python3, the dict.value() method returns an iterator. If a dictionary is updated while an iterator on its keys is used, a RuntimeError is generated. Converting the iterator to a list() forces a copy of the mutable keys in an immutable list which can be safely iterated. Commit f8d11e5a4aaa con