Re: [edk2] [PATCH v2] EmbeddedPkg/MmcDxe: Add alignment for ECSD data

2017-06-14 Thread Leif Lindholm
On Wed, Jun 14, 2017 at 10:50:02AM +0800, Jun Nie wrote: > >> Sorry, just see your email because that thread is not highlighted for > >> new email in gmail for unknown reason. > >> I have concern that "UINT64 VENDOR_SPECIFIC_FIELD[8]" cannot secure > >> the ECSD alignment because it is not the

Re: [edk2] [PATCH v2] EmbeddedPkg/MmcDxe: Add alignment for ECSD data

2017-06-13 Thread Jun Nie
2017-06-13 17:18 GMT+08:00 Leif Lindholm : > On Tue, Jun 13, 2017 at 10:14:34AM +0800, Jun Nie wrote: >> 2017-06-12 23:53 GMT+08:00 Leif Lindholm : >> > On Mon, Jun 12, 2017 at 09:59:28AM +0800, Jun Nie wrote: >> >> Add alignment for ECSD data

Re: [edk2] [PATCH v2] EmbeddedPkg/MmcDxe: Add alignment for ECSD data

2017-06-13 Thread Leif Lindholm
On Tue, Jun 13, 2017 at 10:14:34AM +0800, Jun Nie wrote: > 2017-06-12 23:53 GMT+08:00 Leif Lindholm : > > On Mon, Jun 12, 2017 at 09:59:28AM +0800, Jun Nie wrote: > >> Add alignment for ECSD data for DMA access. Otherwise > >> the data is corrupted on Sanechips platform.

Re: [edk2] [PATCH v2] EmbeddedPkg/MmcDxe: Add alignment for ECSD data

2017-06-12 Thread Jun Nie
2017-06-13 12:25 GMT+08:00 Andrew Fish : > > On Jun 12, 2017, at 9:13 PM, Jun Nie wrote: > > 2017-06-13 12:01 GMT+08:00 Andrew Fish : > > > On Jun 12, 2017, at 7:14 PM, Jun Nie wrote: > > 2017-06-12 23:53 GMT+08:00 Leif

Re: [edk2] [PATCH v2] EmbeddedPkg/MmcDxe: Add alignment for ECSD data

2017-06-12 Thread Andrew Fish
> On Jun 12, 2017, at 9:13 PM, Jun Nie wrote: > > 2017-06-13 12:01 GMT+08:00 Andrew Fish >: >> >>> On Jun 12, 2017, at 7:14 PM, Jun Nie wrote: >>> >>> 2017-06-12 23:53 GMT+08:00 Leif Lindholm

Re: [edk2] [PATCH v2] EmbeddedPkg/MmcDxe: Add alignment for ECSD data

2017-06-12 Thread Jun Nie
2017-06-13 12:01 GMT+08:00 Andrew Fish : > >> On Jun 12, 2017, at 7:14 PM, Jun Nie wrote: >> >> 2017-06-12 23:53 GMT+08:00 Leif Lindholm : >>> On Mon, Jun 12, 2017 at 09:59:28AM +0800, Jun Nie wrote: Add alignment for ECSD data

Re: [edk2] [PATCH v2] EmbeddedPkg/MmcDxe: Add alignment for ECSD data

2017-06-12 Thread Andrew Fish
> On Jun 12, 2017, at 7:14 PM, Jun Nie wrote: > > 2017-06-12 23:53 GMT+08:00 Leif Lindholm : >> On Mon, Jun 12, 2017 at 09:59:28AM +0800, Jun Nie wrote: >>> Add alignment for ECSD data for DMA access. Otherwise >>> the data is corrupted on Sanechips

Re: [edk2] [PATCH v2] EmbeddedPkg/MmcDxe: Add alignment for ECSD data

2017-06-12 Thread Jun Nie
2017-06-12 23:53 GMT+08:00 Leif Lindholm : > On Mon, Jun 12, 2017 at 09:59:28AM +0800, Jun Nie wrote: >> Add alignment for ECSD data for DMA access. Otherwise >> the data is corrupted on Sanechips platform. > > I never did see a reply to my proposed solution, and the

Re: [edk2] [PATCH v2] EmbeddedPkg/MmcDxe: Add alignment for ECSD data

2017-06-12 Thread Andrew Fish
> On Jun 12, 2017, at 8:53 AM, Leif Lindholm wrote: > > On Mon, Jun 12, 2017 at 09:59:28AM +0800, Jun Nie wrote: >> Add alignment for ECSD data for DMA access. Otherwise >> the data is corrupted on Sanechips platform. > > I never did see a reply to my proposed

Re: [edk2] [PATCH v2] EmbeddedPkg/MmcDxe: Add alignment for ECSD data

2017-06-12 Thread Leif Lindholm
On Mon, Jun 12, 2017 at 09:59:28AM +0800, Jun Nie wrote: > Add alignment for ECSD data for DMA access. Otherwise > the data is corrupted on Sanechips platform. I never did see a reply to my proposed solution, and the below is not it. Can you explain why you prefer this one? / Leif >

[edk2] [PATCH v2] EmbeddedPkg/MmcDxe: Add alignment for ECSD data

2017-06-11 Thread Jun Nie
Add alignment for ECSD data for DMA access. Otherwise the data is corrupted on Sanechips platform. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jun Nie --- EmbeddedPkg/Universal/MmcDxe/Mmc.h | 1 + 1 file changed, 1 insertion(+) diff --git