Re: [edk2] [PATCH v2] IntelFsp2Pkg: FSP should not override IDT

2018-10-25 Thread Yao, Jiewen
Reviewed-by: jiewen@intel.com > -Original Message- > From: Chiu, Chasel > Sent: Tuesday, October 23, 2018 5:34 PM > To: edk2-devel@lists.01.org > Cc: Yao, Jiewen ; Desimone, Nathaniel L > ; Chiu, Chasel > Subject: [PATCH v2] IntelFsp2Pkg: FSP should not override IDT > > REF: https://

Re: [edk2] [PATCH v2] IntelFsp2Pkg: FSP should not override IDT

2018-10-23 Thread Chiu, Chasel
Hello, Please see my reply below inline. Thanks! Chasel -Original Message- From: af...@apple.com [mailto:af...@apple.com] Sent: Tuesday, October 23, 2018 6:29 PM To: Chiu, Chasel Cc: edk2-devel@lists.01.org; Yao, Jiewen Subject: Re: [edk2] [PATCH v2] IntelFsp2Pkg: FSP should not

Re: [edk2] [PATCH v2] IntelFsp2Pkg: FSP should not override IDT

2018-10-23 Thread Andrew Fish
> On Oct 23, 2018, at 2:33 AM, Chasel, Chiu wrote: > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1265 > > FSP should not override IDT table when it is initialized > by boot loader. IDT should be re-initialized in FSP only > when it is invalid. > To mitigate temporary memory usage a

[edk2] [PATCH v2] IntelFsp2Pkg: FSP should not override IDT

2018-10-23 Thread Chasel, Chiu
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1265 FSP should not override IDT table when it is initialized by boot loader. IDT should be re-initialized in FSP only when it is invalid. To mitigate temporary memory usage a PCD PcdFspMaxInterruptSupported created for platform to decide how man