Re: [edk2] [PATCH v2] MdeModulePkg: Enable SATA Controller PCI mem space

2018-06-19 Thread Sami Mujawar
eModulePkg: Enable SATA Controller PCI mem space off-topic: On 06/15/18 16:13, Sami Mujawar wrote: > - Enable IO space, suggestion to use EFI_PCI_DEVICE_ENABLE[ZENG] My understanding is that "Star" is Star's given name, and "Zeng" is his surname. Let's not

Re: [edk2] [PATCH v2] MdeModulePkg: Enable SATA Controller PCI mem space

2018-06-18 Thread Zeng, Star
Hi Sami, I will have feedback in the V1 patch thread based on your response there. Thanks, Star -Original Message- From: Sami Mujawar [mailto:sami.muja...@arm.com] Sent: Friday, June 15, 2018 10:14 PM To: edk2-devel@lists.01.org Cc: Zeng, Star ; Dong, Eric ; Ni, Ruiyu ; ard.biesheu...@l

Re: [edk2] [PATCH v2] MdeModulePkg: Enable SATA Controller PCI mem space

2018-06-18 Thread Zeng, Star
; ard.biesheu...@linaro.org; leif.lindh...@linaro.org; nd ; Zeng, Star Subject: Re: [edk2] [PATCH v2] MdeModulePkg: Enable SATA Controller PCI mem space Hi Laszlo, Star. Looking at the e-mail thread, I think I also made the mistake of getting Star's name inverted. I'm sorry, especially as in th

Re: [edk2] [PATCH v2] MdeModulePkg: Enable SATA Controller PCI mem space

2018-06-18 Thread Zeng, Star
: Saturday, June 16, 2018 12:13 AM To: Evan Lloyd Cc: Ni, Ruiyu ; nd ; Stephanie Hughes-Fitt ; Dong, Eric ; Ard Biesheuvel ; edk2-devel@lists.01.org; Zeng, Star Subject: Re: [edk2] [PATCH v2] MdeModulePkg: Enable SATA Controller PCI mem space On Fri, Jun 15, 2018 at 03:26:54PM +, Evan Lloyd

Re: [edk2] [PATCH v2] MdeModulePkg: Enable SATA Controller PCI mem space

2018-06-18 Thread Evan Lloyd
.biesheu...@linaro.org; > leif.lindh...@linaro.org; nd ; star.z...@intel.com > Subject: Re: [edk2] [PATCH v2] MdeModulePkg: Enable SATA Controller PCI > mem space > > off-topic: > > On 06/15/18 16:13, Sami Mujawar wrote: > > - Enable IO space, suggestion to use EF

Re: [edk2] [PATCH v2] MdeModulePkg: Enable SATA Controller PCI mem space

2018-06-18 Thread Laszlo Ersek
off-topic: On 06/15/18 16:13, Sami Mujawar wrote: > - Enable IO space, suggestion to use EFI_PCI_DEVICE_ENABLE[ZENG] My understanding is that "Star" is Star's given name, and "Zeng" is his surname. Let's not start calling each other by surname, shall we? (Email addresses under @intel

Re: [edk2] [PATCH v2] MdeModulePkg: Enable SATA Controller PCI mem space

2018-06-15 Thread Leif Lindholm
On Fri, Jun 15, 2018 at 03:26:54PM +, Evan Lloyd wrote: > Hi Ard, Zeng > > > -Original Message- > > From: Ard Biesheuvel > > Sent: 15 June 2018 15:17 > > To: Sami Mujawar > > Cc: edk2-devel@lists.01.org; Zeng, Star ; Eric Dong > > ; Ruiyu Ni ; Leif Lindholm > > ; Matteo Carlini ; > >

Re: [edk2] [PATCH v2] MdeModulePkg: Enable SATA Controller PCI mem space

2018-06-15 Thread Ard Biesheuvel
On 15 June 2018 at 17:26, Evan Lloyd wrote: > Hi Ard, Zeng > >> -Original Message- >> From: Ard Biesheuvel >> Sent: 15 June 2018 15:17 >> To: Sami Mujawar >> Cc: edk2-devel@lists.01.org; Zeng, Star ; Eric Dong >> ; Ruiyu Ni ; Leif Lindholm >> ; Matteo Carlini ; >> Stephanie Hughes-Fitt ;

Re: [edk2] [PATCH v2] MdeModulePkg: Enable SATA Controller PCI mem space

2018-06-15 Thread Evan Lloyd
Hi Ard, Zeng > -Original Message- > From: Ard Biesheuvel > Sent: 15 June 2018 15:17 > To: Sami Mujawar > Cc: edk2-devel@lists.01.org; Zeng, Star ; Eric Dong > ; Ruiyu Ni ; Leif Lindholm > ; Matteo Carlini ; > Stephanie Hughes-Fitt ; Evan Lloyd > ; Thomas Abraham ; > nd > Subject: Re: [P

Re: [edk2] [PATCH v2] MdeModulePkg: Enable SATA Controller PCI mem space

2018-06-15 Thread Ard Biesheuvel
On 15 June 2018 at 16:13, Sami Mujawar wrote: > The SATA controller driver crashes while accessing the > PCI memory [AHCI Base Registers (ABAR)], as the PCI memory > space is not enabled. > > Enable the PCI memory space access to prevent the SATA > Controller driver from crashing. > > Contributed-

[edk2] [PATCH v2] MdeModulePkg: Enable SATA Controller PCI mem space

2018-06-15 Thread Sami Mujawar
The SATA controller driver crashes while accessing the PCI memory [AHCI Base Registers (ABAR)], as the PCI memory space is not enabled. Enable the PCI memory space access to prevent the SATA Controller driver from crashing. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Sa