Re: [edk2] [PATCH v2] MdeModulePkg: PciHostBridgeDxe: don't assume extended config space

2016-03-01 Thread Ni, Ruiyu
alf Of Laszlo >Ersek >Sent: Tuesday, March 1, 2016 4:48 PM >To: Ni, Ruiyu ; mar...@redhat.com; edk2-de...@ml01.01.org >Cc: Kinney, Michael D ; Justen, Jordan L > >Subject: Re: [edk2] [PATCH v2] MdeModulePkg: PciHostBridgeDxe: don't assume >extended config space >

Re: [edk2] [PATCH v2] MdeModulePkg: PciHostBridgeDxe: don't assume extended config space

2016-03-01 Thread Laszlo Ersek
On 03/01/16 03:11, Ni, Ruiyu wrote: > Laszlo, > > How about using a flag NoExtendedConfigSpace? > > Since for most cases the PCI CFG space limit is 0xFFF, so I think it’s > better to choose a flag whose > > default value meets most of the cases. For a Boolean flag inside a > structure when the s

Re: [edk2] [PATCH v2] MdeModulePkg: PciHostBridgeDxe: don't assume extended config space

2016-02-29 Thread Ni, Ruiyu
] MdeModulePkg: PciHostBridgeDxe: don't assume extended config space Laszlo, How about using a flag NoExtendedConfigSpace? Since for most cases the PCI CFG space limit is 0xFFF, so I think it's better to choose a flag whose default value meets most of the cases. For a Boolean flag inside a

Re: [edk2] [PATCH v2] MdeModulePkg: PciHostBridgeDxe: don't assume extended config space

2016-02-29 Thread Ni, Ruiyu
Laszlo, How about using a flag NoExtendedConfigSpace? Since for most cases the PCI CFG space limit is 0xFFF, so I think it's better to choose a flag whose default value meets most of the cases. For a Boolean flag inside a structure when the structure is allocated using AllocateZeroPool, the flag

Re: [edk2] [PATCH v2] MdeModulePkg: PciHostBridgeDxe: don't assume extended config space

2016-02-29 Thread Marcel Apfelbaum
On 02/29/2016 03:15 PM, Laszlo Ersek wrote: The "pc" ("pc-i440fx-*") machine types of QEMU don't support extended config space. Accordingly, OVMF will use the following library instances in connection with the core PciHostBridgeDxe driver: BasePciSegmentLibPci [class: PciSegmentLib] Base

Re: [edk2] [PATCH v2] MdeModulePkg: PciHostBridgeDxe: don't assume extended config space

2016-02-29 Thread Laszlo Ersek
On 02/29/16 14:15, Laszlo Ersek wrote: > The "pc" ("pc-i440fx-*") machine types of QEMU don't support extended > config space. Accordingly, OVMF will use the following library instances > in connection with the core PciHostBridgeDxe driver: > > BasePciSegmentLibPci [class: PciSegmentLib] > B

[edk2] [PATCH v2] MdeModulePkg: PciHostBridgeDxe: don't assume extended config space

2016-02-29 Thread Laszlo Ersek
The "pc" ("pc-i440fx-*") machine types of QEMU don't support extended config space. Accordingly, OVMF will use the following library instances in connection with the core PciHostBridgeDxe driver: BasePciSegmentLibPci [class: PciSegmentLib] BasePciLibCf8 [class: PciLib] BasePciCf8L