Re: [edk2] [PATCH v2] MdeModulePkg:Add ESC key support in setup browser pop-up message box

2015-07-27 Thread Bi, Dandan
- From: Justen, Jordan L Sent: Tuesday, July 28, 2015 2:33 AM To: Bi, Dandan; Dong, Eric; Gao, Liming; edk2-devel@lists.01.org Subject: RE: [edk2] [PATCH v2] MdeModulePkg:Add ESC key support in setup browser pop-up message box On 2015-07-26 23:57:27, Bi, Dandan wrote: > > .../Uni

Re: [edk2] [PATCH v2] MdeModulePkg:Add ESC key support in setup browser pop-up message box

2015-07-27 Thread Jordan Justen
On 2015-07-26 23:57:27, Bi, Dandan wrote: > > .../Universal/DisplayEngineDxe/FormDisplay.c| 3 ++- > > .../Universal/DisplayEngineDxe/FormDisplayStr.uni | Bin 17032 -> 17056 > > bytes > > What about making 2 patches? The first patch can convert > FormDisplayStr.uni to UTF-8 without c

Re: [edk2] [PATCH v2] MdeModulePkg:Add ESC key support in setup browser pop-up message box

2015-07-27 Thread Gao, Liming
Reviewed-by: Liming Gao -Original Message- From: Bi, Dandan Sent: Monday, July 27, 2015 2:57 PM To: Justen, Jordan L; Dong, Eric; Gao, Liming; edk2-devel@lists.01.org Subject: RE: [edk2] [PATCH v2] MdeModulePkg:Add ESC key support in setup browser pop-up message box Mainly change the

Re: [edk2] [PATCH v2] MdeModulePkg:Add ESC key support in setup browser pop-up message box

2015-07-26 Thread Bi, Dandan
e. Thanks, Dandan -Original Message- From: Justen, Jordan L Sent: Monday, July 27, 2015 2:31 PM To: Bi, Dandan; Dong, Eric; Gao, Liming; edk2-devel@lists.01.org Subject: Re: [edk2] [PATCH v2] MdeModulePkg:Add ESC key support in setup browser pop-up message box On 2015-07-26 22:19:04, Dan

Re: [edk2] [PATCH v2] MdeModulePkg:Add ESC key support in setup browser pop-up message box

2015-07-26 Thread Jordan Justen
On 2015-07-26 22:19:04, Dandan Bi wrote: > When load default value or save changes will pop up message box to let user > confirm,Y means confirm and N means ignore,now add Esc key with the > same function of N key.And change the context of pop up message in .uni file, > now will display "Press 'Y'

[edk2] [PATCH v2] MdeModulePkg:Add ESC key support in setup browser pop-up message box

2015-07-26 Thread Dandan Bi
When load default value or save changes will pop up message box to let user confirm,Y means confirm and N means ignore,now add Esc key with the same function of N key.And change the context of pop up message in .uni file, now will display "Press 'Y' to confirm, 'N'/'ESC' to ignore." Contributed-un