Re: [edk2] [PATCH v2] NetworkPkg: Use UefiBootManagerLib API to create load option.

2016-05-09 Thread Laszlo Ersek
On 05/09/16 13:13, Laszlo Ersek wrote: > On 05/04/16 07:58, Fu Siyuan wrote: >> V2: >> Remove unnecessary ZeroMem and free load option. >> >> This patch updates the HTTP boot driver to use the API in UefiBootManagerLib >> to >> create new load option, to avoid duplicate code. >> >> Cc: Ye Ting >>

Re: [edk2] [PATCH v2] NetworkPkg: Use UefiBootManagerLib API to create load option.

2016-05-09 Thread Laszlo Ersek
On 05/04/16 07:58, Fu Siyuan wrote: > V2: > Remove unnecessary ZeroMem and free load option. > > This patch updates the HTTP boot driver to use the API in UefiBootManagerLib > to > create new load option, to avoid duplicate code. > > Cc: Ye Ting > Cc: Wu Jiaxin > Cc: Ni Ruiyu > Contributed-un

Re: [edk2] [PATCH v2] NetworkPkg: Use UefiBootManagerLib API to create load option.

2016-05-04 Thread Fu, Siyuan
n > > Subject: Re: [edk2] [PATCH v2] NetworkPkg: Use UefiBootManagerLib API to > create load option. > > Hi Siyuan, > I just found a possible memory leak issue with the following code block. > Others look good to me. > + Status = EfiBootManagerAddLoadOptionVariable (&

Re: [edk2] [PATCH v2] NetworkPkg: Use UefiBootManagerLib API to create load option.

2016-05-04 Thread Wang, Sunny (HPS SW)
Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Fu Siyuan Sent: Wednesday, May 04, 2016 1:58 PM To: edk2-devel@lists.01.org Cc: Ye Ting ; Ni Ruiyu ; Wu Jiaxin Subject: [edk2] [PATCH v2] NetworkPkg: Use UefiBootManagerLib API to create load option. V2: Re

Re: [edk2] [PATCH v2] NetworkPkg: Use UefiBootManagerLib API to create load option.

2016-05-04 Thread Ye, Ting
Reviewed-by: Ye Ting -Original Message- From: Fu, Siyuan Sent: Wednesday, May 04, 2016 1:58 PM To: edk2-devel@lists.01.org Cc: Ye, Ting ; Wu, Jiaxin ; Ni, Ruiyu Subject: [PATCH v2] NetworkPkg: Use UefiBootManagerLib API to create load option. V2: Remove unnecessary ZeroMem and free

Re: [edk2] [PATCH v2] NetworkPkg: Use UefiBootManagerLib API to create load option.

2016-05-03 Thread Ni, Ruiyu
Reviewed-by: Ruiyu Ni >-Original Message- >From: Fu, Siyuan >Sent: Wednesday, May 4, 2016 1:58 PM >To: edk2-devel@lists.01.org >Cc: Ye, Ting ; Wu, Jiaxin ; Ni, Ruiyu > >Subject: [PATCH v2] NetworkPkg: Use UefiBootManagerLib API to create load >option. > >V2: >Remove unnecessary ZeroMem

[edk2] [PATCH v2] NetworkPkg: Use UefiBootManagerLib API to create load option.

2016-05-03 Thread Fu Siyuan
V2: Remove unnecessary ZeroMem and free load option. This patch updates the HTTP boot driver to use the API in UefiBootManagerLib to create new load option, to avoid duplicate code. Cc: Ye Ting Cc: Wu Jiaxin Cc: Ni Ruiyu Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Fu