[edk2] [PATCH v2] NetworkPkg:Fix NULL pointer dereference issues.

2015-11-25 Thread Zhang Lubo
v2: *Revise some codes according to the comments. 1.In HttpResponseWorker, check the HttpHeaders in the first used place. 2.In EfiHttpPoll(), check the HttpInstance state outside of if condition. Cc: Ye Ting Cc: Fu Siyuan Cc: Wu Jiaxin

Re: [edk2] [PATCH v2] NetworkPkg:Fix NULL pointer dereference issues.

2015-11-25 Thread Zhang, Lubo
, Jiaxin; Qiu, Shumin Subject: RE: [edk2] [PATCH v2] NetworkPkg:Fix NULL pointer dereference issues. Hi, Lubo Should HttpHeaders always not be a NULL pointer upon a success call of HttpTcpReceiveHeader? If yes, you should use ASSERT here, otherwise the patch is ok with me? Status

Re: [edk2] [PATCH v2] NetworkPkg:Fix NULL pointer dereference issues.

2015-11-25 Thread Fu, Siyuan
<ting...@intel.com>; Fu, Siyuan <siyuan...@intel.com>; Wu, Jiaxin <jiaxin...@intel.com>; Qiu, Shumin <shumin....@intel.com> Subject: [edk2] [PATCH v2] NetworkPkg:Fix NULL pointer dereference issues. v2: *Revise some codes according to the comments. 1.In HttpResponseWorker, chec

Re: [edk2] [PATCH v2] NetworkPkg:Fix NULL pointer dereference issues.

2015-11-25 Thread Wu, Jiaxin
ng; Wu, Jiaxin; Qiu, Shumin Subject: RE: [edk2] [PATCH v2] NetworkPkg:Fix NULL pointer dereference issues. Hi, Lubo Should HttpHeaders always not be a NULL pointer upon a success call of HttpTcpReceiveHeader? If yes, you should use ASSERT here, otherwise the patch is ok with me?

Re: [edk2] [PATCH v2] NetworkPkg:Fix NULL pointer dereference issues.

2015-11-25 Thread Ye, Ting
ng; Wu, Jiaxin; Qiu, Shumin Subject: RE: [edk2] [PATCH v2] NetworkPkg:Fix NULL pointer dereference issues. Hi, Lubo Should HttpHeaders always not be a NULL pointer upon a success call of HttpTcpReceiveHeader? If yes, you should use ASSERT here, otherwise the patch is ok with me?