Re: [edk2] [PATCH v2] SD/eMMC : Fix Command Argument for SD/eMMC R/W operation.

2019-01-30 Thread Leif Lindholm
I updated the subject line to start with EmbeddedPkg: instead. On Thu, Jan 24, 2019 at 07:35:18PM +0530, Meenakshi Aggarwal wrote: > Issue : SD read failure for high capacity cards e.g. 64 GB > i And I dropped the above stray i. Reviewed-by: Leif Lindholm Pushed as b566259c8a. Thanks! >

Re: [edk2] [PATCH v2] SD/eMMC : Fix Command Argument for SD/eMMC R/W operation.

2019-01-29 Thread Meenakshi Aggarwal
Any comments? > -Original Message- > From: Meenakshi Aggarwal > Sent: Tuesday, January 29, 2019 10:13 AM > To: Meenakshi Aggarwal ; > ard.biesheu...@linaro.org; leif.lindh...@linaro.org; edk2-devel@lists.01.org; > jun@linaro.org; haojian.zhu...@linaro.org > Subject: RE: [PATCH v2]

Re: [edk2] [PATCH v2] SD/eMMC : Fix Command Argument for SD/eMMC R/W operation.

2019-01-28 Thread Meenakshi Aggarwal
Hi, Please share review comments. Thanks, Meenakshi > -Original Message- > From: Meenakshi Aggarwal > Sent: Thursday, January 24, 2019 7:35 PM > To: ard.biesheu...@linaro.org; leif.lindh...@linaro.org; edk2- > de...@lists.01.org; jun@linaro.org; haojian.zhu...@linaro.org > Cc:

[edk2] [PATCH v2] SD/eMMC : Fix Command Argument for SD/eMMC R/W operation.

2019-01-24 Thread Meenakshi Aggarwal
Issue : SD read failure for high capacity cards e.g. 64 GB i Reason : Command argument value exceeds 32 bit for block number 0x3787FFF and cant be fit into 32 bit wide SD host controller register. Fix : AccessMode bits [29:30] of OCR is a valid definition to calculate data address for eMMC cards.