Re: [edk2] [PATCH v2] ShellPkg: Fix GCC build fail.

2015-09-17 Thread Ard Biesheuvel
On 17 September 2015 at 14:27, Qiu Shumin wrote: > Difference with previous version: > It's not correct to casts away constness to allow TrimSpaces() to modify > 'commandline'. > This version make a copy of 'commandLine' and work with that in the remainder > of the function. > OK, much better.

[edk2] [PATCH v2] ShellPkg: Fix GCC build fail.

2015-09-17 Thread Qiu Shumin
Difference with previous version: It's not correct to casts away constness to allow TrimSpaces() to modify 'commandline'. This version make a copy of 'commandLine' and work with that in the remainder of the function. Cc: Jaben Carsey Cc: Ruiyu Ni Cc: Yang Jadis Cc: Ard Biesheuvel Contributed