Re: [edk2] [PATCH v2] TFTP : tftp fix for full volume case

2017-10-10 Thread Meenakshi Aggarwal
> > > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf > > > Of Meenakshi Aggarwal > > > Sent: Sunday, October 08, 2017 11:28 PM > > > To: Fu, Siyuan ; edk2-devel@lists.01.org; Ni, > > > Ruiyu ; Carsey, Jaben ; > > > Ye, T

Re: [edk2] [PATCH v2] TFTP : tftp fix for full volume case

2017-10-09 Thread Ni, Ruiyu
; edk2-devel@lists.01.org; Ni, > > Ruiyu ; Carsey, Jaben ; > > Ye, Ting > > Subject: Re: [edk2] [PATCH v2] TFTP : tftp fix for full volume case > > Importance: High > > > > Hi Team, > > > > > > Any further comments on this patch? > > >

Re: [edk2] [PATCH v2] TFTP : tftp fix for full volume case

2017-10-09 Thread Carsey, Jaben
, Jaben ; Ye, Ting > > Subject: Re: [edk2] [PATCH v2] TFTP : tftp fix for full volume case > Importance: High > > Hi Team, > > > Any further comments on this patch? > > Or is it ready to merge in edk2? > > > Thanks, > Meenakshi > > > -O

Re: [edk2] [PATCH v2] TFTP : tftp fix for full volume case

2017-10-08 Thread Meenakshi Aggarwal
Hi Team, Any further comments on this patch? Or is it ready to merge in edk2? Thanks, Meenakshi > -Original Message- > From: Meenakshi Aggarwal > Sent: Wednesday, September 27, 2017 9:01 AM > To: 'Fu, Siyuan' ; edk2-devel@lists.01.org; Ni, Ruiyu > ; Carsey, Jaben ; Ye, Ting > > Cc: U

Re: [edk2] [PATCH v2] TFTP : tftp fix for full volume case

2017-09-26 Thread Meenakshi Aggarwal
Hi, Thanks for the review Siyuan. Ting, Any comment from your side? Thanks, Meenakshi > -Original Message- > From: Fu, Siyuan [mailto:siyuan...@intel.com] > Sent: Tuesday, September 26, 2017 6:12 AM > To: Meenakshi Aggarwal ; edk2- > de...@lists.01.org; Ni, Ruiyu ; Carsey, Jaben > >

Re: [edk2] [PATCH v2] TFTP : tftp fix for full volume case

2017-09-25 Thread Fu, Siyuan
Reviewed-by: Fu Siyuan -Original Message- From: Meenakshi Aggarwal [mailto:meenakshi.aggar...@nxp.com] Sent: Monday, September 25, 2017 11:06 PM To: edk2-devel@lists.01.org; Ni, Ruiyu ; Carsey, Jaben Cc: ard.biesheu...@linaro.org; leif.lindh...@linaro.org; Fu, Siyuan ; Ye, Ting ; Meen

[edk2] [PATCH v2] TFTP : tftp fix for full volume case

2017-09-25 Thread Meenakshi Aggarwal
Issue : When storage media is full, tftp was resulting in ASSERT MdeModulePkg/Core/Dxe/Mem/Page.c, because number of pages was zero. Reason: While doing tftp, function call ShellWriteFile was modifying FileSize variable. In case of full disk it was coming out to be Zero. Fix: Storage the original